lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <169761797261.48072.1075267340140520177.kvalo@kernel.org> Date: Wed, 18 Oct 2023 08:32:54 +0000 (UTC) From: Kalle Valo <kvalo@...nel.org> To: Justin Stitt <justinstitt@...gle.com> Cc: linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org, Justin Stitt <justinstitt@...gle.com> Subject: Re: [PATCH] ath6kl: replace deprecated strncpy with memcpy Justin Stitt <justinstitt@...gle.com> wrote: > strncpy() is deprecated for use on NUL-terminated destination strings > [1] and as such we should prefer more robust and less ambiguous > interfaces. > > The affected code's purpose is to truncate strings that are too long > with "..." like: > foobar -> fo... > > The lengths have been carefully calculated and as such this has decayed > to a simple byte copy from one buffer to another -- let's use memcpy(). > > Note: build-tested only. > > Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings [1] > Link: https://github.com/KSPP/linux/issues/90 > Cc: linux-hardening@...r.kernel.org > Signed-off-by: Justin Stitt <justinstitt@...gle.com> > Signed-off-by: Kalle Valo <quic_kvalo@...cinc.com> Patch applied to ath-next branch of ath.git, thanks. 40990961d983 wifi: ath6kl: replace deprecated strncpy with memcpy -- https://patchwork.kernel.org/project/linux-wireless/patch/20231013-strncpy-drivers-net-wireless-ath-ath6kl-init-c-v1-1-d69c599b49a9@google.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Powered by blists - more mailing lists