linux-hardening - Re: [PATCH] PCI: pciehp: Prevent child devices from doing RPM on PCIe Link Down

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202310171955.hlish6FZ-lkp@intel.com>
Date: Thu, 19 Oct 2023 09:06:10 +0800
From: kernel test robot <yujie.liu@...el.com>
To: Kai-Heng Feng <kai.heng.feng@...onical.com>, <bhelgaas@...gle.com>
CC: <oe-kbuild-all@...ts.linux.dev>, <linux-pm@...r.kernel.org>,
	<linux-mmc@...r.kernel.org>, Kai-Heng Feng <kai.heng.feng@...onical.com>,
	Ricky Wu <ricky_wu@...ltek.com>, Kees Cook <keescook@...omium.org>, Tony Luck
	<tony.luck@...el.com>, "Guilherme G. Piccoli" <gpiccoli@...lia.com>, "Lukas
 Wunner" <lukas@...ner.de>, <linux-pci@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <linux-hardening@...r.kernel.org>,
	<bpf@...r.kernel.org>
Subject: Re: [PATCH] PCI: pciehp: Prevent child devices from doing RPM on
 PCIe Link Down

Hi Kai-Heng,

kernel test robot noticed the following build warnings:

[auto build test WARNING on pci/next]
[also build test WARNING on pci/for-linus linus/master v6.6-rc6 next-20231017]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Kai-Heng-Feng/PCI-pciehp-Prevent-child-devices-from-doing-RPM-on-PCIe-Link-Down/20231017-142208
base:   https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git next
patch link:    https://lore.kernel.org/r/20231016040132.23824-1-kai.heng.feng%40canonical.com
patch subject: [PATCH] PCI: pciehp: Prevent child devices from doing RPM on PCIe Link Down
config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20231017/202310171955.hlish6FZ-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231017/202310171955.hlish6FZ-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <yujie.liu@...el.com>
| Closes: https://lore.kernel.org/r/202310171955.hlish6FZ-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/pci/hotplug/pciehp_pci.c:25:5: warning: no previous prototype for 'pci_dev_disconnect' [-Wmissing-prototypes]
      25 | int pci_dev_disconnect(struct pci_dev *pdev, void *unused)
         |     ^~~~~~~~~~~~~~~~~~


vim +/pci_dev_disconnect +25 drivers/pci/hotplug/pciehp_pci.c

^1da177e4c3f41 Linus Torvalds 2005-04-16  24  
2bd1cb5c4e6711 Kai-Heng Feng  2023-10-16 @25  int pci_dev_disconnect(struct pci_dev *pdev, void *unused)
2bd1cb5c4e6711 Kai-Heng Feng  2023-10-16  26  {
2bd1cb5c4e6711 Kai-Heng Feng  2023-10-16  27  	pm_runtime_barrier(&pdev->dev);
2bd1cb5c4e6711 Kai-Heng Feng  2023-10-16  28  	pci_dev_set_disconnected(pdev, NULL);
2bd1cb5c4e6711 Kai-Heng Feng  2023-10-16  29  
2bd1cb5c4e6711 Kai-Heng Feng  2023-10-16  30  	return 0;
2bd1cb5c4e6711 Kai-Heng Feng  2023-10-16  31  }
2bd1cb5c4e6711 Kai-Heng Feng  2023-10-16  32  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki