lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Thu, 19 Oct 2023 17:16:53 -0700
From: Kees Cook <>
To: Justin Stitt <>
Cc: Gregory Greenman <>,
	Kalle Valo <>,,,
Subject: Re: [PATCH v2] wifi: iwlwifi: fw: replace deprecated strncpy with

On Thu, Oct 19, 2023 at 05:44:59PM +0000, Justin Stitt wrote:
> strncpy() is deprecated for use on NUL-terminated destination strings
> [1] and as such we should prefer more robust and less ambiguous string
> interfaces.
> Based on the deliberate `sizeof(dest) ... - 1` pattern we can see that
> both dump_info->dev_human_readable and dump_info->bus_human_readable are
> intended to be NUL-terminated.
> Moreover, since this seems to cross the file boundary let's NUL-pad to
> ensure no behavior change.
> strscpy_pad() covers both the NUL-termination and NUL-padding, let's use
> it.
> Link: [1]
> Link:
> Cc:
> Signed-off-by: Justin Stitt <>

Thanks for the respin!

Reviewed-by: Kees Cook <>

Kees Cook

Powered by blists - more mailing lists