lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <90328e09-5e48-4bd0-ac67-62a104b6eb76@quicinc.com> Date: Tue, 24 Oct 2023 07:11:51 -0700 From: Jeff Johnson <quic_jjohnson@...cinc.com> To: Kalle Valo <kvalo@...nel.org>, Justin Stitt <justinstitt@...gle.com> CC: <ath10k@...ts.infradead.org>, <linux-wireless@...r.kernel.org>, <linux-kernel@...r.kernel.org>, <linux-hardening@...r.kernel.org> Subject: Re: [PATCH] ath10k: replace deprecated strncpy with strtomem_pad On 10/24/2023 6:03 AM, Kalle Valo wrote: > What about using just memcpy() to make it clear it's not really a proper > string: > > arvif->u.ap.ssid_len = 4; > memcpy(arvif->u.ap.ssid, "mesh", arvif->u.ap.ssid_len); > In the "changed & BSS_CHANGED_SSID" case that comes soon after this we just set the length and use memcpy without clearing the rest of the buffer, so doing the same here, as you suggest, would be consistent. /jeff
Powered by blists - more mailing lists