lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 24 Oct 2023 10:28:48 -0700
From: Kees Cook <>
To: Justin Stitt <>
Cc: Alexandra Winter <>,
	Wenjia Zhang <>,
	Heiko Carstens <>,
	Vasily Gorbik <>,
	Alexander Gordeev <>,
	Christian Borntraeger <>,
	Sven Schnelle <>,,,,
Subject: Re: [PATCH] s390/ctcm: replace deprecated strncpy with strscpy

On Mon, Oct 23, 2023 at 07:35:07PM +0000, Justin Stitt wrote:
> strncpy() is deprecated for use on NUL-terminated destination strings
> [1] and as such we should prefer more robust and less ambiguous string
> interfaces.
> We expect chid to be NUL-terminated based on its use with format
> strings:
> 			chid, ok ? "OK" : "failed");
> Moreover, NUL-padding is not required as it is _only_ used in this one
> instance with a format string.
> Considering the above, a suitable replacement is `strscpy` [2] due to
> the fact that it guarantees NUL-termination on the destination buffer
> without unnecessarily NUL-padding.
> We can also drop the +1 from chid's declaration as we no longer need to
> be cautious about leaving a spot for a NUL-byte. Let's use the more
> idiomatic strscpy usage of (dest, src, sizeof(dest)) as this more
> closely ties the destination buffer to the length.
> Link: [1]
> Link: [2]
> Link:
> Cc:
> Signed-off-by: Justin Stitt <>

Yeah, all looks correct to me.

Reviewed-by: Kees Cook <>

Kees Cook

Powered by blists - more mailing lists