lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Thu, 26 Oct 2023 10:45:28 -0700
From: Kees Cook <>
To: Justin Stitt <>
Cc: James Smart <>,
	Ram Vegesna <>,
	"James E.J. Bottomley" <>,
	"Martin K. Petersen" <>,,,,
Subject: Re: [PATCH v2] scsi: elx: libefc: replace deprecated strncpy with

On Thu, Oct 26, 2023 at 01:53:13AM +0000, Justin Stitt wrote:
> strncpy() is deprecated for use on NUL-terminated destination strings
> [1] and as such we should prefer more robust and less ambiguous string
> interfaces.
> To keep node->current_state_name and node->prev_state_name NUL-padded
> and NUL-terminated let's use strscpy_pad() as this implicitly provides
> both.
> For the swap between the two, a simple memcpy will suffice.
> Link: [1]
> Link: [2]
> Link:
> Cc:
> Signed-off-by: Justin Stitt <>

Thanks! I think this looks good now.

Reviewed-by: Kees Cook <>

Kees Cook

Powered by blists - more mailing lists