lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Thu, 26 Oct 2023 14:02:47 -0400
From: Steven Rostedt <>
To: Kees Cook <>
Cc: "Matthew Wilcox (Oracle)" <>, Christoph Hellwig
 <>, Justin Stitt <>, Kent Overstreet
 <>, Petr Mladek <>, Andy
 Shevchenko <>, Rasmus Villemoes
 <>, Sergey Senozhatsky <>,
 Masami Hiramatsu <>, Greg Kroah-Hartman
 <>, Arnd Bergmann <>, Jonathan
 Corbet <>, Yun Zhou <>, Jacob Keller
 <>, Zhen Lei <>,, Yosry Ahmed <>,,
Subject: Re: [PATCH] seq_buf: Introduce DECLARE_SEQ_BUF and seq_buf_cstr()

On Thu, 26 Oct 2023 10:54:26 -0700
Kees Cook <> wrote:

> > Do we really need to call it _cstr? Why not just have seq_buf_str() ?
> > 
> > I mean, this is C, do we need to state that in the name too?  
> I'm fine either way. I did that just to make the distinction between our
> length-managed string of characters interface (seq_buf), and the
> %NUL-terminated string of characters (traditionally called "C String" in
> other languages). And it was still shorter than "seq_buf_terminate(s);
> s->buffer" ;)

Do you believe that people might get confused with it as seq_buf_str()?

Can you envision that we would want a seq_buf_str() and seq_buf_cstr() that
do something different?

-- Steve

Powered by blists - more mailing lists