lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Fri, 27 Oct 2023 09:18:57 -0700
From: Kees Cook <>
To: Justin Stitt <>
Cc: Jonathan Cameron <>,
	Lars-Peter Clausen <>,,,
Subject: Re: [PATCH v2] iio: sx9324: avoid copying property strings

On Thu, Oct 26, 2023 at 11:53:28PM +0000, Justin Stitt wrote:
> We're doing some needless string copies when trying to assign the proper
> `prop` string. We can make `prop` a const char* and simply assign to
> string literals.
> For the case where a format string is used, let's allocate some memory
> via kasprintf() and point prop to it.
> This also cleans up some deprecated strncpy() uses [1].
> Link: [1]
> Link:
> Cc:
> Signed-off-by: Justin Stitt <>

Looks like a reasonable way to go.

Reviewed-by: Kees Cook <>

Kees Cook

Powered by blists - more mailing lists