lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sat, 11 Nov 2023 04:08:28 +0800
From: David Gow <>
To: Nathan Chancellor <>, Kees Cook <>, 
	Brendan Higgins <>, Rae Moar <>,, 
	Maxime Ripard <>, Arthur Grillo <>, 
	Shuah Khan <>
Cc: David Gow <>, 
	"MaĆ­ra Canal" <>, Sami Tolvanen <>,,,,, 
	Benjamin Berg <>, Richard Fitzgerald <>,, 
	Maarten Lankhorst <>, Thomas Zimmermann <>, 
	Emma Anholt <>, David Airlie <>, Daniel Vetter <>,
Subject: [PATCH 3/3] drm/vc4: tests: Use KUNIT_DEFINE_ACTION_WRAPPER

In order to pass functions to kunit_add_action(), they need to be of the
kunit_action_t type. While casting the function pointer can work, it
will break control-flow integrity.

vc4_mock already defines such a wrapper for drm_dev_unregister(), but it
involves less boilerplate to use the new macro, so replace the manual

Signed-off-by: David Gow <>

This patch should be a no-op, just moving to use a standard macro to
implement these wrappers rather than hand-coding them.

Let me know if you'd prefer to take these in separately via the drm
trees, or if you're okay with having this whole series go via

-- David

 drivers/gpu/drm/vc4/tests/vc4_mock.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/vc4/tests/vc4_mock.c b/drivers/gpu/drm/vc4/tests/vc4_mock.c
index 63ca46f4cb35..becb3dbaa548 100644
--- a/drivers/gpu/drm/vc4/tests/vc4_mock.c
+++ b/drivers/gpu/drm/vc4/tests/vc4_mock.c
@@ -153,12 +153,9 @@ static int __build_mock(struct kunit *test, struct drm_device *drm,
 	return 0;
-static void kunit_action_drm_dev_unregister(void *ptr)
-	struct drm_device *drm = ptr;
-	drm_dev_unregister(drm);
+			    drm_dev_unregister,
+			    struct drm_device *);
 static struct vc4_dev *__mock_device(struct kunit *test, bool is_vc5)

Powered by blists - more mailing lists