linux-hardening - Re: [PATCH 2/3] drm/tests: Use KUNIT_DEFINE_ACTION

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6gfqtuhscq2z2obvx3xh6ve4kj5hrqniyegfywldtx2vowdp5z@ikix547w3vff>
Date: Wed, 15 Nov 2023 16:50:41 +0100
From: Maxime Ripard <mripard@...nel.org>
To: David Gow <davidgow@...gle.com>
Cc: Nathan Chancellor <nathan@...nel.org>, 
	Kees Cook <keescook@...omium.org>, Brendan Higgins <brendan.higgins@...ux.dev>, 
	Rae Moar <rmoar@...gle.com>, dlatypov@...gle.com, Arthur Grillo <arthurgrillo@...eup.net>, 
	Shuah Khan <skhan@...uxfoundation.org>, Maíra Canal <mairacanal@...eup.net>, 
	Sami Tolvanen <samitolvanen@...gle.com>, kunit-dev@...glegroups.com, llvm@...ts.linux.dev, 
	linux-hardening@...r.kernel.org, linux-kselftest@...r.kernel.org, 
	Benjamin Berg <benjamin.berg@...el.com>, Richard Fitzgerald <rf@...nsource.cirrus.com>, 
	linux-kernel@...r.kernel.org, Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, 
	Thomas Zimmermann <tzimmermann@...e.de>, Emma Anholt <emma@...olt.net>, David Airlie <airlied@...il.com>, 
	Daniel Vetter <daniel@...ll.ch>, dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH 2/3] drm/tests: Use KUNIT_DEFINE_ACTION_WRAPPER()

Hi David,

On Sat, Nov 11, 2023 at 04:08:27AM +0800, David Gow wrote:
> In order to pass functions to kunit_add_action(), they need to be of the
> kunit_action_t type. While casting the function pointer can work, it
> will break control-flow integrity.
> 
> drm_kunit_helpers already defines wrappers, but we now have a macro
> which does this automatically. Using this greatly reduces the
> boilerplate needed.
> 
> Signed-off-by: David Gow <davidgow@...gle.com>
> ---
> 
> This patch should be a no-op, just moving to use a standard macro to
> implement these wrappers rather than hand-coding them.
> 
> Let me know if you'd prefer to take these in separately via the drm
> trees, or if you're okay with having this whole series go via
> kselftest/kunit.

You can merge it through your tree with

Acked-by: Maxime Ripard <mripard@...nel.org>

For the patches 2 and 3

Maxime

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)