lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 15 Nov 2023 16:50:41 +0100
From: Maxime Ripard <>
To: David Gow <>
Cc: Nathan Chancellor <>, 
	Kees Cook <>, Brendan Higgins <>, 
	Rae Moar <>,, Arthur Grillo <>, 
	Shuah Khan <>, MaĆ­ra Canal <>, 
	Sami Tolvanen <>,,,,, 
	Benjamin Berg <>, Richard Fitzgerald <>,, Maarten Lankhorst <>, 
	Thomas Zimmermann <>, Emma Anholt <>, David Airlie <>, 
	Daniel Vetter <>,
Subject: Re: [PATCH 2/3] drm/tests: Use KUNIT_DEFINE_ACTION_WRAPPER()

Hi David,

On Sat, Nov 11, 2023 at 04:08:27AM +0800, David Gow wrote:
> In order to pass functions to kunit_add_action(), they need to be of the
> kunit_action_t type. While casting the function pointer can work, it
> will break control-flow integrity.
> drm_kunit_helpers already defines wrappers, but we now have a macro
> which does this automatically. Using this greatly reduces the
> boilerplate needed.
> Signed-off-by: David Gow <>
> ---
> This patch should be a no-op, just moving to use a standard macro to
> implement these wrappers rather than hand-coding them.
> Let me know if you'd prefer to take these in separately via the drm
> trees, or if you're okay with having this whole series go via
> kselftest/kunit.

You can merge it through your tree with

Acked-by: Maxime Ripard <>

For the patches 2 and 3


Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)

Powered by blists - more mailing lists