lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Date: Thu, 16 Nov 2023 11:14:52 -0800
From: Kees Cook <>
To: Greg Kroah-Hartman <>
Cc: Kees Cook <>,
	Will McVicker <>,
	"Gustavo A. R. Silva" <>,
	Peter Chen <>,
	Davidlohr Bueso <>,
	Zhang Qilong <>,
	Linyu Yuan <>,
	John Keeping <>,
	Azeem Shaikh <>,,,
Subject: [PATCH] usb: gadget: f_midi: Replace strlcpy() with strscpy()

strlcpy() reads the entire source buffer first. This read may exceed
the destination size limit. This is both inefficient and can lead
to linear read overflows if a source string is not NUL-terminated[1].
Additionally, it returns the size of the source string, not the
resulting size of the destination string. In an effort to remove strlcpy()
completely[2], replace strlcpy() here with strscpy().

In the unlikely (impossible?) case where opts->id was larger than
PAGE_SIZE, this will now correctly report truncation errors.

Link: [1]
Link: [2]
Cc: Greg Kroah-Hartman <>
Cc: Will McVicker <>
Cc: "Gustavo A. R. Silva" <>
Cc: Peter Chen <>
Cc: Davidlohr Bueso <>
Cc: Zhang Qilong <>
Cc: Linyu Yuan <>
Cc: John Keeping <>
Cc: Azeem Shaikh <>
Signed-off-by: Kees Cook <>
 drivers/usb/gadget/function/f_midi.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/gadget/function/f_midi.c b/drivers/usb/gadget/function/f_midi.c
index 5335845d697b..20c6fbd94f32 100644
--- a/drivers/usb/gadget/function/f_midi.c
+++ b/drivers/usb/gadget/function/f_midi.c
@@ -1177,11 +1177,11 @@ F_MIDI_OPT(out_ports, true, MAX_PORTS);
 static ssize_t f_midi_opts_id_show(struct config_item *item, char *page)
 	struct f_midi_opts *opts = to_f_midi_opts(item);
-	int result;
+	ssize_t result;
 	if (opts->id) {
-		result = strlcpy(page, opts->id, PAGE_SIZE);
+		result = strscpy(page, opts->id, PAGE_SIZE);
 	} else {
 		page[0] = 0;
 		result = 0;

Powered by blists - more mailing lists