lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Fri, 17 Nov 2023 10:50:21 -0800
From: "T.J. Mercier" <>
To: Kees Cook <>
Cc: Sumit Semwal <>,,, Azeem Shaikh <>,,, 
	Christian König <>,
Subject: Re: [PATCH] dma-buf: Replace strlcpy() with strscpy()

On Thu, Nov 16, 2023 at 11:14 AM Kees Cook <> wrote:
> strlcpy() reads the entire source buffer first. This read may exceed
> the destination size limit. This is both inefficient and can lead
> to linear read overflows if a source string is not NUL-terminated[1].
> Additionally, it returns the size of the source string, not the
> resulting size of the destination string. In an effort to remove strlcpy()
> completely[2], replace strlcpy() here with strscpy().
> Link: [1]
> Link: [2]
> Cc: Sumit Semwal <>
> Cc: "Christian König" <>
> Cc: Azeem Shaikh <>
> Cc:
> Cc:
> Cc:
> Signed-off-by: Kees Cook <>

Reviewed-by: T.J. Mercier <>

strscpy returns -E2BIG when it truncates / force null-terminates which
would provide the wrong argument for dynamic_dname, but
dma_buf_set_name{_user} makes sure we have a null-terminated string of
the appropriate maximum size in dmabuf->name.

Powered by blists - more mailing lists