linux-hardening - Re: [PATCH] scsi: 3w-sas: replace deprecated strncpy with strscpy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <170087016623.1036733.12314891671424643121.b4-ty@oracle.com>
Date: Fri, 24 Nov 2023 21:54:14 -0500
From: "Martin K. Petersen" <martin.petersen@...cle.com>
To: Adam Radford <aradford@...il.com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        Justin Stitt <justinstitt@...gle.com>
Cc: "Martin K . Petersen" <martin.petersen@...cle.com>,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-hardening@...r.kernel.org
Subject: Re: [PATCH] scsi: 3w-sas: replace deprecated strncpy with strscpy

On Mon, 23 Oct 2023 19:50:57 +0000, Justin Stitt wrote:

> strncpy() is deprecated for use on NUL-terminated destination strings
> [1] and as such we should prefer more robust and less ambiguous string
> interfaces.
> 
> This pattern of strncpy(dest, src, strlen(src)) is extremely bug-prone.
> This pattern basically never results in NUL-terminated destination
> strings unless `dest` was zero-initialized. The current implementation
> may be accidentally correct as tw_dev is zero-allocated via:
> 
> [...]

Applied to 6.8/scsi-queue, thanks!

[1/1] scsi: 3w-sas: replace deprecated strncpy with strscpy
      https://git.kernel.org/mkp/scsi/c/7936a19e944b

-- 
Martin K. Petersen	Oracle Linux Engineering