linux-hardening - Re: [PATCH] samples: Replace strlcpy() with strscpy()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <170137701899.3640290.1090297958877884765.b4-ty@chromium.org>
Date: Thu, 30 Nov 2023 12:43:41 -0800
From: Kees Cook <keescook@...omium.org>
To: Masami Hiramatsu <mhiramat@...nel.org>,
	Kees Cook <keescook@...omium.org>
Cc: Valentin Schneider <vschneid@...hat.com>,
	"Steven Rostedt (Google)" <rostedt@...dmis.org>,
	Chuck Lever <chuck.lever@...cle.com>,
	Geliang Tang <geliang.tang@...e.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Christophe JAILLET <christophe.jaillet@...adoo.fr>,
	Thomas Gleixner <tglx@...utronix.de>,
	Arnd Bergmann <arnd@...db.de>,
	linux-kernel@...r.kernel.org,
	linux-hardening@...r.kernel.org
Subject: Re: [PATCH] samples: Replace strlcpy() with strscpy()

On Thu, 16 Nov 2023 11:15:10 -0800, Kees Cook wrote:
> strlcpy() reads the entire source buffer first. This read may exceed
> the destination size limit. This is both inefficient and can lead
> to linear read overflows if a source string is not NUL-terminated[1].
> Additionally, it returns the size of the source string, not the
> resulting size of the destination string. In an effort to remove strlcpy()
> completely[2], replace strlcpy() here with strscpy().
> 
> [...]

Applied to for-next/hardening, thanks!

[1/1] samples: Replace strlcpy() with strscpy()
      https://git.kernel.org/kees/c/40b2519d7566

Take care,

-- 
Kees Cook