| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <874jh2rtuk.fsf@kernel.org> Date: Fri, 01 Dec 2023 14:27:15 +0200 From: Kalle Valo <kvalo@...nel.org> To: Kees Cook <keescook@...omium.org> Cc: Justin Stitt <justinstitt@...gle.com>, Gregory Greenman <gregory.greenman@...el.com>, linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org Subject: Re: [PATCH v2] wifi: iwlwifi: fw: replace deprecated strncpy with strscpy_pad Kees Cook <keescook@...omium.org> writes: > On Thu, Oct 19, 2023 at 05:44:59PM +0000, Justin Stitt wrote: >> strncpy() is deprecated for use on NUL-terminated destination strings >> [1] and as such we should prefer more robust and less ambiguous string >> interfaces. >> >> Based on the deliberate `sizeof(dest) ... - 1` pattern we can see that >> both dump_info->dev_human_readable and dump_info->bus_human_readable are >> intended to be NUL-terminated. >> >> Moreover, since this seems to cross the file boundary let's NUL-pad to >> ensure no behavior change. >> >> strscpy_pad() covers both the NUL-termination and NUL-padding, let's use >> it. >> >> Link: >> https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings >> [1] >> Link: https://github.com/KSPP/linux/issues/90 >> Cc: linux-hardening@...r.kernel.org >> Signed-off-by: Justin Stitt <justinstitt@...gle.com> > > Thread ping. Can the wireless folks please pick this up? Yeah, I'll take this directly to wireless-next. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Powered by blists - more mailing lists