| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202312052114.VQD1viY5-lkp@intel.com>
Date: Tue, 5 Dec 2023 21:53:56 +0800
From: kernel test robot <lkp@...el.com>
To: davidgow@...gle.com, Rae Moar <rmoar@...gle.com>,
Brendan Higgins <brendan.higgins@...ux.dev>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Matti Vaittinen <matti.vaittinen@...rohmeurope.com>,
Matti Vaittinen <mazziesaccount@...il.com>,
Stephen Boyd <sboyd@...nel.org>,
Shuah Khan <skhan@...uxfoundation.org>,
Jonathan Corbet <corbet@....net>, Kees Cook <keescook@...omium.org>,
Liam Girdwood <lgirdwood@...il.com>,
Mark Brown <broonie@...nel.org>, Jaroslav Kysela <perex@...ex.cz>,
Takashi Iwai <tiwai@...e.com>, Maxime Ripard <mripard@...nel.org>
Cc: oe-kbuild-all@...ts.linux.dev, linux-kselftest@...r.kernel.org,
kunit-dev@...glegroups.com, linux-doc@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org,
linux-sound@...r.kernel.org, David Gow <davidgow@...gle.com>
Subject: Re: [PATCH 1/4] kunit: Add APIs for managing devices
Hi,
kernel test robot noticed the following build warnings:
[auto build test WARNING on c8613be119892ccceffbc550b9b9d7d68b995c9e]
url: https://github.com/intel-lab-lkp/linux/commits/davidgow-google-com/kunit-Add-APIs-for-managing-devices/20231205-153349
base: c8613be119892ccceffbc550b9b9d7d68b995c9e
patch link: https://lore.kernel.org/r/20231205-kunit_bus-v1-1-635036d3bc13%40google.com
patch subject: [PATCH 1/4] kunit: Add APIs for managing devices
config: powerpc-randconfig-r081-20231205 (https://download.01.org/0day-ci/archive/20231205/202312052114.VQD1viY5-lkp@intel.com/config)
compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project.git 4a5ac14ee968ff0ad5d2cc1ffa0299048db4c88a)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231205/202312052114.VQD1viY5-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202312052114.VQD1viY5-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> lib/kunit/device.c:100:22: warning: no previous prototype for function '__kunit_device_register_internal' [-Wmissing-prototypes]
100 | struct kunit_device *__kunit_device_register_internal(struct kunit *test,
| ^
lib/kunit/device.c:100:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
100 | struct kunit_device *__kunit_device_register_internal(struct kunit *test,
| ^
| static
1 warning generated.
vim +/__kunit_device_register_internal +100 lib/kunit/device.c
99
> 100 struct kunit_device *__kunit_device_register_internal(struct kunit *test,
101 const char *name,
102 struct device_driver *drv)
103 {
104 struct kunit_device *kunit_dev;
105 int err = -ENOMEM;
106
107 kunit_dev = kzalloc(sizeof(struct kunit_device), GFP_KERNEL);
108 if (!kunit_dev)
109 return ERR_PTR(err);
110
111 kunit_dev->owner = test;
112
113 err = dev_set_name(&kunit_dev->dev, "%s.%s", test->name, name);
114 if (err) {
115 kfree(kunit_dev);
116 return ERR_PTR(err);
117 }
118
119 /* Set the expected driver pointer, so we match. */
120 kunit_dev->driver = drv;
121
122 kunit_dev->dev.release = kunit_device_release;
123 kunit_dev->dev.bus = &kunit_bus_type;
124 kunit_dev->dev.parent = &kunit_bus;
125
126 err = device_register(&kunit_dev->dev);
127 if (err) {
128 put_device(&kunit_dev->dev);
129 return ERR_PTR(err);
130 }
131
132 kunit_add_action(test, device_unregister_wrapper, &kunit_dev->dev);
133
134 return kunit_dev;
135 }
136
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists