lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <ZXG_pumoDp88qIuw@smile.fi.intel.com> Date: Thu, 7 Dec 2023 14:50:46 +0200 From: Andy Shevchenko <andy@...nel.org> To: Nick Desaulniers <ndesaulniers@...gle.com> Cc: Greg KH <greg@...ah.com>, Al Viro <viro@...iv.linux.org.uk>, tanzirh@...gle.com, Kees Cook <keescook@...omium.org>, linux-hardening@...r.kernel.org, linux-kernel@...r.kernel.org, Nick DeSaulniers <nnn@...gle.com>, Andrew Morton <akpm@...ux-foundation.org>, llvm@...ts.linux.dev Subject: Re: [PATCH] lib/string: shrink lib/string.i via IWYU On Tue, Dec 05, 2023 at 02:14:55PM -0800, Nick Desaulniers wrote: > On Tue, Dec 5, 2023 at 1:59 PM Greg KH <greg@...ah.com> wrote: ... > For example, lib/math/int_log.c includes asm/bug.h. Is that a case > where lib/math/int_log.c should be #include 'ing linux/bug.h rather > than asm/bug.h? For the C-files it's fine to include linux/* versions of asm/* ones, for the _headers_ I would prefer to be strictly minimalistic, because of possible header dependency hell. If something is defined in asm/* and some header wants to use that, it's better to include asm/*. -- With Best Regards, Andy Shevchenko
Powered by blists - more mailing lists