lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Fri, 8 Dec 2023 09:22:55 -0800
From: Kees Cook <>
Cc: Shay Agroskin <>,
	Arthur Kiyanovski <>,
	David Arinzon <>, Noam Dagan <>,
	Saeed Bishara <>,
	"David S. Miller" <>,
	Eric Dumazet <>,
	Jakub Kicinski <>, Paolo Abeni <>,,,
Subject: Re: [PATCH v2] net: ena: replace deprecated strncpy with strscpy

On Thu, Dec 07, 2023 at 09:34:42PM +0000, wrote:
> `strncpy` is deprecated for use on NUL-terminated destination strings
> [1] and as such we should prefer more robust and less ambiguous string
> interfaces.
> A suitable replacement is `strscpy` [2] due to the fact that it
> guarantees NUL-termination on the destination buffer without
> unnecessarily NUL-padding.
> host_info allocation is done in ena_com_allocate_host_info() via
> dma_alloc_coherent() and is not zero initialized by alloc_etherdev_mq().
> However zero initialization of the destination doesn't matter in this case,
> because strscpy() guarantees a NULL termination.
> Link: [1]
> Link: [2]
> Link:
> Cc:
> Signed-off-by: Justin Stitt <>

Yeah, this reads much better.

Reviewed-by: Kees Cook <>

Kees Cook

Powered by blists - more mailing lists