lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAFhGd8p76R-oaPWR0G6wESe7kgM--2bzU88j2vz4QGy8wKNffg@mail.gmail.com> Date: Mon, 11 Dec 2023 16:46:20 -0800 From: Justin Stitt <justinstitt@...gle.com> To: Stephen Boyd <swboyd@...omium.org> Cc: Jonathan Cameron <jic23@...nel.org>, Lars-Peter Clausen <lars@...afoo.de>, linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org, Gwendal Grignou <gwendal@...omium.org> Subject: Re: [PATCH v2] iio: sx9324: avoid copying property strings Hi, On Mon, Oct 30, 2023 at 2:44 PM Stephen Boyd <swboyd@...omium.org> wrote: > > > We need to free it in other places too, like if the count doesn't match. > It may be easier to extract this section and just have 4 string > literals. > > switch (reg_def->reg) { > case SX9324_REG_AFE_PH0: > reg_def = sx9324_parse_phase_prop(dev, reg_def, "semtech,ph0-pin"); > break; > case SX9324_REG_AFE_PH1: > reg_def = sx9324_parse_phase_prop(dev, reg_def, "semtech,ph1-pin"); > break; > case SX9324_REG_AFE_PH2: > reg_def = sx9324_parse_phase_prop(dev, reg_def, "semtech,ph2-pin"); > break; > case SX9324_REG_AFE_PH3: > reg_def = sx9324_parse_phase_prop(dev, reg_def, "semtech,ph3-pin"); > break; > I've submitted v3 of this patch [1] trying out Stephen's idea. I'd appreciate feedback. [1]: https://lore.kernel.org/all/20231212-strncpy-drivers-iio-proximity-sx9324-c-v3-1-b8ae12fc8a5d@google.com/ Thanks Justin
Powered by blists - more mailing lists