lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 12 Dec 2023 13:26:14 -0800
From: Kees Cook <>
To: Justin Stitt <>
Cc: Jonathan Cameron <>,
	Lars-Peter Clausen <>,
	Stephen Boyd <>,,,
Subject: Re: [PATCH v3] iio: sx9324: avoid copying property strings

On Tue, Dec 12, 2023 at 12:42:52AM +0000, Justin Stitt wrote:
> We're doing some needless string copies when trying to assign the proper
> `prop` string. We can make `prop` a const char* and simply assign to
> string literals.
> For the case where a format string is used, let's extract the parsing
> logic out into sx9324_parse_phase_prop(). We no longer need to create
> copies or allocate new memory.
> sx9324_parse_phase_prop() will simply return the default def value if it
> fails.
> This also cleans up some deprecated strncpy() uses [1].
> Link: [1]
> Link:
> Cc:
> Signed-off-by: Justin Stitt <>

Yeah, I like this approach. Totally removes the string copying and
creates a helper that does the "heavy lifting". :)

Reviewed-by: Kees Cook <>

Kees Cook

Powered by blists - more mailing lists