lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <7b14aa01-24c2-425c-8bf3-48e5b7890b95@linux.ibm.com> Date: Thu, 14 Dec 2023 09:04:41 -0600 From: Ninad Palsule <ninad@...ux.ibm.com> To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org, joel@....id.au, andrew@...econstruct.com.au, peterhuewe@....de, jarkko@...nel.org, jgg@...pe.ca, keescook@...omium.org, tony.luck@...el.com, gpiccoli@...lia.com, johannes.holland@...ineon.com, linux@...ck-us.net, broonie@...nel.org Cc: patrick.rudolph@...ements.com, vincent@...emblay.dev, peteryin.openbmc@...il.com, lakshmiy@...ibm.com, bhelgaas@...gle.com, naresh.solanki@...ements.com, alexander.stein@...tq-group.com, festevam@...x.de, devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-aspeed@...ts.ozlabs.org, linux-kernel@...r.kernel.org, linux-integrity@...r.kernel.org, linux-hardening@...r.kernel.org, geissonator@...oo.com Subject: Re: [PATCH v1 8/8] ARM: dts: aspeed: System1: PS, sensor and more Hello Krzysztof, On 12/12/23 14:26, Krzysztof Kozlowski wrote: > On 12/12/2023 17:40, Ninad Palsule wrote: >> This drop adds following devices in the device tree. >> - EEPROM/VPD >> - Power supplies >> - Humidity, pressure and temperature sensors. >> - Trusted platform module(TPM) chip >> >> Tested: >> This board is tested using the simics simulator. >> >> Signed-off-by: Ninad Palsule <ninad@...ux.ibm.com> >> --- > Don't mix DTS with drivers. DTS and drivers go via different subsystems > and cannot have dependencies, so why DTS is patch #6, then driver #7 and > now again DTS #7? I have sent a driver patch as a separate patchset and removed it from this patchset. > > >> .../dts/aspeed/aspeed-bmc-ibm-system1.dts | 76 +++++++++++++++++++ >> 1 file changed, 76 insertions(+) >> >> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts >> index 75562aa63701..d960b938fe8d 100644 >> --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts >> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts >> @@ -461,6 +461,11 @@ &kcs3 { >> &i2c0 { >> status = "okay"; >> >> + eeprom@50 { >> + compatible = "atmel,24c64"; >> + reg = <0x50>; >> + }; >> + >> regulator@60 { >> compatible = "maxim,max8952"; >> reg = <0x60>; >> @@ -655,6 +660,25 @@ pca0: pca9539@74 { >> >> &i2c2 { >> status = "okay"; >> + >> + power-supply@58 { >> + compatible = "ibm,cffps"; >> + reg = <0x58>; >> + }; >> + >> + power-supply@59 { >> + compatible = "ibm,cffps"; >> + reg = <0x59>; >> + }; >> + >> + power-supply@5a { >> + compatible = "ibm,cffps"; >> + reg = <0x5a>; >> + }; > Missing blank line Fixed it. Thanks for the review. Regards, Ninad > >> + power-supply@5b { >> + compatible = "ibm,cffps"; >> + reg = <0x5b>; >> + }; > > Best regards, > Krzysztof >
Powered by blists - more mailing lists