lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 19 Dec 2023 23:51:43 +0200
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Tanzir Hasan <tanzirh@...gle.com>
Cc: Kees Cook <keescook@...omium.org>, Nick Desaulniers <nnn@...gle.com>, 
	Andy Shevchenko <andy@...nel.org>, linux-hardening@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Andrew Morton <akpm@...ux-foundation.org>, 
	Greg KH <gregkh@...uxfoundation.org>, llvm@...ts.linux.dev, 
	Al Viro <viro@...iv.linux.org.uk>
Subject: Re: [PATCH v5 1/2] kernel.h: removed REPEAT_BYTE from kernel.h

On Tue, Dec 19, 2023 at 8:48 PM Tanzir Hasan <tanzirh@...gle.com> wrote:
>
> This patch creates wordpart.h and includes it in asm/word-at-a-time.h
> for the all architectures. WORD_AT_A_TIME_CONSTANTS depends on kernel.h
> because of REPEAT_BYTE. Moving this to another header and including it
> where necessary allows us to not include the bloated kernel.h. Making
> this implicit dependency on REPEAT_BYTE explicit allows for later
> improvements in the lib/string.c inclusion list.

Same comments as per v4 apply here.
According to the Submitting Patches the best time between versions is
~1w. I understand your desire to close this quicker, but the result is
actually the opposite. Take your time and check carefully what others
commented and recommended. With this series it's fine to send a couple
of times per (working) week. It sounds to me balanced between the
complexity of the change and the people's willingness (having time?)
to review.

Otherwise it's a good start!

-- 
With Best Regards,
Andy Shevchenko

Powered by blists - more mailing lists