linux-hardening - Re: [PATCH] scripts: kernel-doc: Bug fixed for erroneous warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4155c90e-cdb1-4645-8bcc-fed4ea01ac83@infradead.org>
Date: Tue, 19 Dec 2023 22:29:06 -0800
From: Randy Dunlap <rdunlap@...radead.org>
To: Muhammad Muzammil <m.muzzammilashraf@...il.com>, corbet@....net,
 gustavoars@...nel.org
Cc: linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-hardening@...r.kernel.org
Subject: Re: [PATCH] scripts: kernel-doc: Bug fixed for erroneous warning

Hi,

On 12/19/23 22:24, Muhammad Muzammil wrote:
> From: Muzammil Ashraf <m.muzzammilashraf@...il.com>
> 
> kernel-doc: fixed erroneous warning generated by '__counted_by'
> 
> Signed-off-by: Muzammil Ashraf <m.muzzammilashraf@...il.com>
> ---
>  scripts/kernel-doc | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/scripts/kernel-doc b/scripts/kernel-doc
> index 1484127db104..ea9688df0e93 100755
> --- a/scripts/kernel-doc
> +++ b/scripts/kernel-doc
> @@ -1661,6 +1661,7 @@ sub check_sections($$$$$) {
>  			}
>  			elsif (($decl_type eq "struct") or
>  		       	       ($decl_type eq "union")) {
> +                next if (index("@_", "__counted_by") != -1);
>  				emit_warning("${file}:$.",
>  					"Excess $decl_type member " .
>  					"'$sects[$sx]' " .

One of both of these patches should be enough. Can you test these
instead of your patch, please?

https://lore.kernel.org/linux-doc/20231215001347.work.151-kees@kernel.org/

https://lore.kernel.org/linux-doc/87le9rjb4y.fsf@meer.lwn.net/

Thanks.

-- 
#Randy
https://people.kernel.org/tglx/notes-about-netiquette
https://subspace.kernel.org/etiquette.html