lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Fri, 22 Dec 2023 09:58:04 +0900
From: Tejun Heo <>
To: Kees Cook <>
Cc: Greg Kroah-Hartman <>,
	Azeem Shaikh <>,
	Zefan Li <>,
	Johannes Weiner <>,
	Waiman Long <>,
	Christophe JAILLET <>,,,,
Subject: Re: [PATCH v3 1/3] kernfs: Convert kernfs_walk_ns() from strlcpy()
 to strscpy()

On Tue, Dec 12, 2023 at 01:17:38PM -0800, Kees Cook wrote:
> strlcpy() reads the entire source buffer first. This read may exceed
> the destination size limit. This is both inefficient and can lead
> to linear read overflows if a source string is not NUL-terminated[1].
> Additionally, it returns the size of the source string, not the
> resulting size of the destination string. In an effort to remove strlcpy()
> completely[2], replace strlcpy() here with strscpy().
> Link: [1]
> Link: [2]
> Cc: Greg Kroah-Hartman <>
> Cc: Tejun Heo <>
> Cc: Azeem Shaikh <>
> Link:
> Signed-off-by: Kees Cook <>

Acked-by: Tejun Heo <>



Powered by blists - more mailing lists