linux-hardening - Re: [PATCH v2 00/18] sysctl: constify sysctl ctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231221124421.6zil5v3nhiidw2a7@localhost>
Date: Thu, 21 Dec 2023 13:44:21 +0100
From: Joel Granados <j.granados@...sung.com>
To: Thomas Weißschuh <linux@...ssschuh.net>
CC: Luis Chamberlain <mcgrof@...nel.org>, Julia Lawall
	<julia.lawall@...ia.fr>, Dan Carpenter <dan.carpenter@...aro.org>, Kees Cook
	<keescook@...omium.org>, "Gustavo A. R. Silva" <gustavoars@...nel.org>,
	Iurii Zaikin <yzaikin@...gle.com>, Greg Kroah-Hartman
	<gregkh@...uxfoundation.org>, <linux-hardening@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <linux-fsdevel@...r.kernel.org>
Subject: Re: [PATCH v2 00/18] sysctl: constify sysctl ctl_tables

On Tue, Dec 19, 2023 at 08:29:50PM +0100, Thomas Weißschuh wrote:
> Hi Luis and Julia,
> 
> (Julia, there is a question and context for you inline, marked with your name)
> 
> On 2023-12-18 13:21:49-0800, Luis Chamberlain wrote:
> > So we can split this up concentually in two:
> > 
> >  * constificaiton of the table handlers
> >  * constification of the table struct itself
<--- snip --->
> > case but to any place in the kernel where this previously has been done
> > before, and hence my suggestion that this seems like a sensible thing
> > to think over to see if we could generalize.
> 
> I'd like to split the series and submit the part up until and including
> the constification of arguments first and on its own.
> It keeps the subsystem maintainers out of the discussion of the core
> sysctl changes.
quick comment : Note that if this contains the tree-wide patches, it
will inevitably bring in the rest of the maintainers.

> 
> I'll submit the core sysctl changes after I figure out proper responses
> to all review comments and we can do this in parallel to the tree-wide
> preparation.
> 
> What do you think Luis and Joel?
Separating all this into patch series that have a defined motivation and
that are self contained is the way to go IMO.

Best
> 
> [0] https://protect2.fireeye.com/v1/url?k=0ddcce36-6d3e536b-0ddd4579-000babd9f1ba-c68841e97c452963&q=1&e=d70f9b65-8465-4489-b777-b13eb1ffc99b&u=https%3A%2F%2Frepo.or.cz%2Fsmatch.git%2Fblob%2FHEAD%3A%2Fsmatch_scripts%2Ftest_kernel.sh

-- 

Joel Granados

Download attachment "signature.asc" of type "application/pgp-signature" (660 bytes)