linux-hardening - Re: [PATCH] ARM: unwind: Add missing "Call trace:" line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <549d8438-cae7-4c81-8f2e-1513a5e2dd5d@collabora.com>
Date: Thu, 11 Jan 2024 13:12:23 +0100
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
To: Kees Cook <keescook@...omium.org>, Russell King <linux@...linux.org.uk>
Cc: Mark Brown <broonie@...nel.org>, Ard Biesheuvel <ardb@...nel.org>,
 Arnd Bergmann <arnd@...db.de>, Linus Walleij <linus.walleij@...aro.org>,
 Vladimir Murzin <vladimir.murzin@....com>,
 Zhen Lei <thunder.leizhen@...wei.com>, Keith Packard <keithpac@...zon.com>,
 Haibo Li <haibo.li@...iatek.com>, linux-arm-kernel@...ts.infradead.org,
 Matthias Brugger <matthias.bgg@...il.com>,
 Alexandre Mergnat <amergnat@...libre.com>, linux-kernel@...r.kernel.org,
 linux-hardening@...r.kernel.org
Subject: Re: [PATCH] ARM: unwind: Add missing "Call trace:" line

Il 10/01/24 22:56, Kees Cook ha scritto:
> Every other architecture in Linux includes the line "Call trace:" before
> backtraces. In some cases ARM would print "Backtrace:", but this was
> only via 1 specific call path, and wasn't included in CPU Oops nor things
> like KASAN, UBSAN, etc that called dump_stack(). Regularize this line
> so CI systems and other things (like LKDTM) that depend on parsing
> "Call trace:" out of dmesg will see it for ARM.
> 
> Before this patch:
> 
> 	UBSAN: array-index-out-of-bounds in ../drivers/misc/lkdtm/bugs.c:376:16
> 	index 8 is out of range for type 'char [8]'
> 	CPU: 0 PID: 1402 Comm: cat Not tainted 6.7.0-rc2 #1
> 	Hardware name: Generic DT based system
> 	 dump_backtrace from show_stack+0x20/0x24
> 	 r7:00000042 r6:00000000 r5:60070013 r4:80cf5d7c
> 	 show_stack from dump_stack_lvl+0x88/0x98
> 	 dump_stack_lvl from dump_stack+0x18/0x1c
> 	 r7:00000042 r6:00000008 r5:00000008 r4:80fab118
> 	 dump_stack from ubsan_epilogue+0x10/0x3c
> 	 ubsan_epilogue from __ubsan_handle_out_of_bounds+0x80/0x84
> 	...
> 
> After this patch:
> 
> 	UBSAN: array-index-out-of-bounds in ../drivers/misc/lkdtm/bugs.c:376:16
> 	index 8 is out of range for type 'char [8]'
> 	CPU: 0 PID: 1402 Comm: cat Not tainted 6.7.0-rc2 #1
> 	Hardware name: Generic DT based system
> 	Call trace:
> 	 dump_backtrace from show_stack+0x20/0x24
> 	 r7:00000042 r6:00000000 r5:60070013 r4:80cf5d7c
> 	 show_stack from dump_stack_lvl+0x88/0x98
> 	 dump_stack_lvl from dump_stack+0x18/0x1c
> 	 r7:00000042 r6:00000008 r5:00000008 r4:80fab118
> 	 dump_stack from ubsan_epilogue+0x10/0x3c
> 	 ubsan_epilogue from __ubsan_handle_out_of_bounds+0x80/0x84
> 	...
> 
> Reported-by: Mark Brown <broonie@...nel.org>
> Cc: Russell King <linux@...linux.org.uk>
> Cc: Ard Biesheuvel <ardb@...nel.org>
> Cc: Arnd Bergmann <arnd@...db.de>
> Cc: Linus Walleij <linus.walleij@...aro.org>
> Cc: Vladimir Murzin <vladimir.murzin@....com>
> Cc: Zhen Lei <thunder.leizhen@...wei.com>
> Cc: Keith Packard <keithpac@...zon.com>
> Cc: Haibo Li <haibo.li@...iatek.com>
> Cc: linux-arm-kernel@...ts.infradead.org
> Signed-off-by: Kees Cook <keescook@...omium.org>

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>