linux-hardening - Re: [PATCH] efi: pstore: Allow dynamic initialization based on module parameter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <706a5008-331b-34ea-c177-bb0070375099@igalia.com>
Date: Mon, 15 Jan 2024 18:20:45 -0300
From: "Guilherme G. Piccoli" <gpiccoli@...lia.com>
To: linux-efi@...r.kernel.org
Cc: ardb@...nel.org, keescook@...omium.org, tony.luck@...el.com,
 linux-hardening@...r.kernel.org, kernel@...ccoli.net, kernel-dev@...lia.com
Subject: Re: [PATCH] efi: pstore: Allow dynamic initialization based on module
 parameter

On 03/01/2024 15:40, Guilherme G. Piccoli wrote:
> The efi-pstore module parameter "pstore_disable" warrants that users
> are able to deactivate such backend. There is also a Kconfig option
> for the default value of this parameter. It was originally added due
> to some bad UEFI FW implementations that could break with many variables
> written.
> 
> Some distros (such as Arch Linux) set this in their config file still
> nowadays. And once it is set, even being a writable module parameter,
> there is effectively no way to make use of efi-pstore anymore.
> If "pstore_disable" is set to true, the init function of the module exits
> early and is never called again after the initcall processing.
> 
> Let's switch this module parameter to have a callback and perform the
> pstore backend registration again each time it's set from Y->N (and
> vice-versa). With this, the writable nature of the parameter starts to
> make sense, given that users now can switch back to using efi-pstore
> or not during runtime by writing into it.

Hi folks, a friendly ping - any comments on this one, suggestions?
Thanks in advance,

Guilherme