linux-hardening - Re: [PATCH] crypto: qat - use kcalloc_node() instead of kzalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Za+uDX8DyggIGs9V@gcabiddu-mobl.ger.corp.intel.com>
Date: Tue, 23 Jan 2024 12:16:13 +0000
From: "Cabiddu, Giovanni" <giovanni.cabiddu@...el.com>
To: Erick Archer <erick.archer@....com>
CC: Herbert Xu <herbert@...dor.apana.org.au>, "David S. Miller"
	<davem@...emloft.net>, Tero Kristo <tero.kristo@...ux.intel.com>, "Andy
 Shevchenko" <andriy.shevchenko@...ux.intel.com>, Damian Muszynski
	<damian.muszynski@...el.com>, Shashank Gupta <shashank.gupta@...el.com>, "Tom
 Zanussi" <tom.zanussi@...ux.intel.com>, "Gustavo A. R. Silva"
	<gustavoars@...nel.org>, <qat-linux@...el.com>,
	<linux-crypto@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<linux-hardening@...r.kernel.org>
Subject: Re: [PATCH] crypto: qat - use kcalloc_node() instead of
 kzalloc_node()

On Sun, Jan 21, 2024 at 05:40:43PM +0100, Erick Archer wrote:
> As noted in the "Deprecated Interfaces, Language Features, Attributes,
> and Conventions" documentation [1], size calculations (especially
> multiplication) should not be performed in memory allocator (or similar)
> function arguments due to the risk of them overflowing. This could lead
> to values wrapping around and a smaller allocation being made than the
> caller was expecting. Using those allocations could lead to linear
> overflows of heap memory and other misbehaviors.
> 
> So, use the purpose specific kcalloc_node() function instead of the
> argument count * size in the kzalloc_node() function.
> 
> Link: https://www.kernel.org/doc/html/next/process/deprecated.html#open-coded-arithmetic-in-allocator-arguments [1]
> Link: https://github.com/KSPP/linux/issues/162
> Signed-off-by: Erick Archer <erick.archer@....com>
Acked-by: Giovanni Cabiddu <giovanni.cabiddu@...el.com>