linux-hardening - Re: [PATCH v2] scsi: ibmvscsi_tgt: replace deprecated strncpy with strscpy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Mon, 29 Jan 2024 21:27:04 -0500
From: "Martin K. Petersen" <martin.petersen@...cle.com>
To: Michael Cyr <mikecyr@...ux.ibm.com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        Justin Stitt <justinstitt@...gle.com>
Cc: "Martin K . Petersen" <martin.petersen@...cle.com>,
        linux-scsi@...r.kernel.org, target-devel@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org
Subject: Re: [PATCH v2] scsi: ibmvscsi_tgt: replace deprecated strncpy with strscpy

On Tue, 12 Dec 2023 01:20:20 +0000, Justin Stitt wrote:

> strncpy() is deprecated for use on NUL-terminated destination strings
> [1] and as such we should prefer more robust and less ambiguous string
> interfaces.
> 
> We don't need the NUL-padding behavior that strncpy() provides as vscsi
> is NUL-allocated in ibmvscsis_probe() which proceeds to call
> ibmvscsis_adapter_info():
> |       vscsi = kzalloc(sizeof(*vscsi), GFP_KERNEL);
> 
> [...]

Applied to 6.9/scsi-queue, thanks!

[1/1] scsi: ibmvscsi_tgt: replace deprecated strncpy with strscpy
      https://git.kernel.org/mkp/scsi/c/165470fb2600

-- 
Martin K. Petersen	Oracle Linux Engineering