linux-hardening - Re: [PATCH] sh: Fix build with CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <494586ed5a0871cf7cfd005f513577952306a0bc.camel@physik.fu-berlin.de>
Date: Wed, 31 Jan 2024 12:03:44 +0100
From: John Paul Adrian Glaubitz <glaubitz@...sik.fu-berlin.de>
To: Kees Cook <keescook@...omium.org>, Yoshinori Sato
	 <ysato@...rs.sourceforge.jp>
Cc: kernel test robot <lkp@...el.com>, Rich Felker <dalias@...c.org>, 
 Masahiro Yamada <masahiroy@...nel.org>, Nicolas Schier <n.schier@....de>,
 linux-sh@...r.kernel.org,  linux-kernel@...r.kernel.org,
 linux-hardening@...r.kernel.org
Subject: Re: [PATCH] sh: Fix build with CONFIG_UBSAN=y

Hi Kees,

On Tue, 2024-01-30 at 15:27 -0800, Kees Cook wrote:
> The early boot stub for sh had UBSan instrumentation present where it is
> not supported. Disable it for this part of the build.
> 
>   sh4-linux-ld: arch/sh/boot/compressed/misc.o: in function `zlib_inflate_table':
>   misc.c:(.text+0x670): undefined reference to `__ubsan_handle_shift_out_of_bounds'
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202401310416.s8HLiLnC-lkp@intel.com/
> Cc: Yoshinori Sato <ysato@...rs.sourceforge.jp>
> Cc: Rich Felker <dalias@...c.org>
> Cc: John Paul Adrian Glaubitz <glaubitz@...sik.fu-berlin.de>
> Cc: Masahiro Yamada <masahiroy@...nel.org>
> Cc: Nicolas Schier <n.schier@....de>
> Cc: linux-sh@...r.kernel.org
> Signed-off-by: Kees Cook <keescook@...omium.org>
> ---
>  arch/sh/boot/compressed/Makefile | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/sh/boot/compressed/Makefile b/arch/sh/boot/compressed/Makefile
> index b5e29f99c02c..6c6c791a1d06 100644
> --- a/arch/sh/boot/compressed/Makefile
> +++ b/arch/sh/boot/compressed/Makefile
> @@ -12,6 +12,7 @@ targets := vmlinux vmlinux.bin vmlinux.bin.gz vmlinux.bin.bz2 \
>             vmlinux.bin.lzma vmlinux.bin.xz vmlinux.bin.lzo $(OBJECTS)
>  
>  GCOV_PROFILE := n
> +UBSAN_SANITIZE := n
>  
>  #
>  # IMAGE_OFFSET is the load offset of the compression loader

Thanks for the patch. I'm looking into this now and will provide the review later.

Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer
`. `'   Physicist
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913