linux-hardening - Re: [PATCH] efi: pstore: Allow dynamic initialization based on module parameter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <170681050420.3736595.3520971124875660694.b4-ty@chromium.org>
Date: Thu,  1 Feb 2024 10:01:46 -0800
From: Kees Cook <keescook@...omium.org>
To: ardb@...nel.org,
	linux-efi@...r.kernel.org,
	"Guilherme G. Piccoli" <gpiccoli@...lia.com>
Cc: Kees Cook <keescook@...omium.org>,
	tony.luck@...el.com,
	linux-hardening@...r.kernel.org,
	kernel@...ccoli.net,
	kernel-dev@...lia.com
Subject: Re: [PATCH] efi: pstore: Allow dynamic initialization based on module parameter

On Wed, 03 Jan 2024 15:40:32 -0300, Guilherme G. Piccoli wrote:
> The efi-pstore module parameter "pstore_disable" warrants that users
> are able to deactivate such backend. There is also a Kconfig option
> for the default value of this parameter. It was originally added due
> to some bad UEFI FW implementations that could break with many variables
> written.
> 
> Some distros (such as Arch Linux) set this in their config file still
> nowadays. And once it is set, even being a writable module parameter,
> there is effectively no way to make use of efi-pstore anymore.
> If "pstore_disable" is set to true, the init function of the module exits
> early and is never called again after the initcall processing.
> 
> [...]

Applied to for-next/pstore, thanks!

[1/1] efi: pstore: Allow dynamic initialization based on module parameter
      https://git.kernel.org/kees/c/c3f849caf81b

Take care,

-- 
Kees Cook