linux-hardening - Re: [PATCH 10/10] scsi: arcmsr: Remove snprintf() from sysfs call-backs and replace with sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202402092313.DF1409889@keescook>
Date: Fri, 9 Feb 2024 23:13:28 -0800
From: Kees Cook <keescook@...omium.org>
To: Lee Jones <lee@...nel.org>
Cc: linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org,
	"James E.J. Bottomley" <jejb@...ux.ibm.com>,
	"Martin K. Petersen" <martin.petersen@...cle.com>,
	support@...ca.com.tw, linux-scsi@...r.kernel.org
Subject: Re: [PATCH 10/10] scsi: arcmsr: Remove snprintf() from sysfs
 call-backs and replace with sysfs_emit()

On Thu, Feb 08, 2024 at 08:44:22AM +0000, Lee Jones wrote:
> Since snprintf() has the documented, but still rather strange trait of
> returning the length of the data that *would have been* written to the
> array if space were available, rather than the arguably more useful
> length of data *actually* written, it is usually considered wise to use
> something else instead in order to avoid confusion.
> 
> In the case of sysfs call-backs, new wrappers exist that do just that.
> 
> Link: https://lwn.net/Articles/69419/
> Link: https://github.com/KSPP/linux/issues/105
> Signed-off-by: Lee Jones <lee@...nel.org>

Reviewed-by: Kees Cook <keescook@...omium.org>

-- 
Kees Cook