linux-hardening - Re: [PATCH v3] wifi: mwifiex: Refactor 1-element array into flexible array in struct mwifiex_ie_types_chan_list_param

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <170775228681.2851594.6070070242483330161.kvalo@kernel.org>
Date: Mon, 12 Feb 2024 15:38:08 +0000 (UTC)
From: Kalle Valo <kvalo@...nel.org>
To: Kees Cook <keescook@...omium.org>
Cc: Brian Norris <briannorris@...omium.org>,
 Kees Cook <keescook@...omium.org>, Dmitry Antipov <dmantipov@...dex.ru>,
 Johannes Berg <johannes.berg@...el.com>, zuoqilin <zuoqilin@...ong.com>,
 Ruan Jinjie <ruanjinjie@...wei.com>, Thomas Gleixner <tglx@...utronix.de>,
 Christophe JAILLET <christophe.jaillet@...adoo.fr>,
 "Gustavo A . R . Silva" <gustavoars@...nel.org>,
 linux-wireless@...r.kernel.org, Dan Carpenter <error27@...il.com>,
 Francesco Dolcini <francesco.dolcini@...adex.com>,
 David Lin <yu-hao.lin@....com>, Lukas Wunner <lukas@...ner.de>,
 Simon Horman <horms@...nel.org>, linux-kernel@...r.kernel.org,
 linux-hardening@...r.kernel.org
Subject: Re: [PATCH v3] wifi: mwifiex: Refactor 1-element array into flexible
 array in struct mwifiex_ie_types_chan_list_param_set

Kees Cook <keescook@...omium.org> wrote:

> struct mwifiex_ie_types_chan_list_param_set::chan_scan_param is treated
> as a flexible array, so convert it into one so that it doesn't trip
> the array bounds sanitizer[1]. Only a few places were using sizeof()
> on the whole struct, so adjust those to follow the calculation pattern
> to avoid including the trailing single element.
> 
> Examining binary output differences doesn't appear to show any literal
> size values changing, though it is obfuscated a bit by the compiler
> adjusting register usage and stack spill slots, etc.
> 
> Link: https://github.com/KSPP/linux/issues/51 [1]
> Cc: Brian Norris <briannorris@...omium.org>
> Cc: Kalle Valo <kvalo@...nel.org>
> Cc: Dmitry Antipov <dmantipov@...dex.ru>
> Cc: Johannes Berg <johannes.berg@...el.com>
> Cc: zuoqilin <zuoqilin@...ong.com>
> Cc: Ruan Jinjie <ruanjinjie@...wei.com>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> Cc: Gustavo A. R. Silva <gustavoars@...nel.org>
> Cc: linux-wireless@...r.kernel.org
> Signed-off-by: Kees Cook <keescook@...omium.org>
> Reviewed-by: Gustavo A. R. Silva <gustavoars@...nel.org>

Patch applied to wireless-next.git, thanks.

14ddc470ba22 wifi: mwifiex: Refactor 1-element array into flexible array in struct mwifiex_ie_types_chan_list_param_set

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20240207103024.make.423-kees@kernel.org/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches