linux-hardening - Coverity: virtsnd_kctl_tlv_op(): Uninitialized variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <202402121051.B091CCC4B@keescook>
Date: Mon, 12 Feb 2024 10:51:50 -0800
From: coverity-bot <keescook@...omium.org>
To: Anton Yakovlev <anton.yakovlev@...nsynergy.com>
Cc: Jason Wang <jasowang@...hat.com>, Takashi Iwai <tiwai@...e.de>,
	Takashi Iwai <tiwai@...e.com>, linux-kernel@...r.kernel.org,
	virtualization@...ts.linux.dev, Jaroslav Kysela <perex@...ex.cz>,
	alsa-devel@...a-project.org, linux-sound@...r.kernel.org,
	Aiswarya Cyriac <aiswarya.cyriac@...nsynergy.com>,
	Xuan Zhuo <xuanzhuo@...ux.alibaba.com>,
	"Michael S. Tsirkin" <mst@...hat.com>,
	"Gustavo A. R. Silva" <gustavo@...eddedor.com>,
	linux-next@...r.kernel.org, linux-hardening@...r.kernel.org
Subject: Coverity: virtsnd_kctl_tlv_op(): Uninitialized variables

Hello!

This is an experimental semi-automated report about issues detected by
Coverity from a scan of next-20240212 as part of the linux-next scan project:
https://scan.coverity.com/projects/linux-next-weekly-scan

You're getting this email because you were associated with the identified
lines of code (noted below) that were touched by commits:

  Fri Feb 9 14:01:15 2024 +0100
    d6568e3de42d ("ALSA: virtio: add support for audio controls")

Coverity reported the following:

*** CID 1583619:  Uninitialized variables  (UNINIT)
sound/virtio/virtio_kctl.c:294 in virtsnd_kctl_tlv_op()
288
289     		break;
290     	}
291
292     	kfree(tlv);
293
vvv     CID 1583619:  Uninitialized variables  (UNINIT)
vvv     Using uninitialized value "rc".
294     	return rc;
295     }
296
297     /**
298      * virtsnd_kctl_get_enum_items() - Query items for the ENUMERATED element type.
299      * @snd: VirtIO sound device.

If this is a false positive, please let us know so we can mark it as
such, or teach the Coverity rules to be smarter. If not, please make
sure fixes get into linux-next. :) For patches fixing this, please
include these lines (but double-check the "Fixes" first):

Reported-by: coverity-bot <keescook+coverity-bot@...omium.org>
Addresses-Coverity-ID: 1583619 ("Uninitialized variables")
Fixes: d6568e3de42d ("ALSA: virtio: add support for audio controls")

Thanks for your attention!

(Human comment: looks like there's no "default" case in the switch
statement.)

-- 
Coverity-bot