linux-hardening - Re: [PATCH] lib/string_choices: Add str

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <93abcadb-591f-45dc-a07d-f67745eddcd6@intel.com>
Date: Thu, 15 Feb 2024 18:14:34 +0100
From: Michal Wajdeczko <michal.wajdeczko@...el.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: Jani Nikula <jani.nikula@...el.com>, Kees Cook <keescook@...omium.org>,
 linux-hardening@...r.kernel.org
Subject: Re: [PATCH] lib/string_choices: Add str_plural() helper



On 15.02.2024 18:05, Andy Shevchenko wrote:
> On Thu, Feb 15, 2024 at 05:55:43PM +0100, Michal Wajdeczko wrote:
>> On 15.02.2024 17:11, Andy Shevchenko wrote:
>>> On Thu, Feb 15, 2024 at 04:37:18PM +0100, Michal Wajdeczko wrote:
>>>> On 15.02.2024 16:20, Jani Nikula wrote:
>>>>> On Wed, 14 Feb 2024, Kees Cook <keescook@...omium.org> wrote:
>>>>>> On Wed, Feb 14, 2024 at 08:49:39PM +0200, Andy Shevchenko wrote:
> 
> ...
> 
>>>>>> Or a Coccinelle script that could do some rewrites? But, yes, if you can
>>>>>> include some examples, that would be nice. I think the helper is fine to
>>>>>> add.
>>>>
>>>> please find below requested Coccinelle script:
>>>
>>> Thanks!
>>>
>>> Btw, what to do with 0?
>>
>> code is based on this rule:
>>
>> "With countable nouns, zero is always followed by plural nouns."
> 
> If it's not documented / commented, please add one.

but this is a rule of the English language, no ?
do we really have to repeat it in the code ?