linux-hardening - Re: [PATCH 8/9] drm/xe/tests: Fix printf format specifiers in xe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ee268c7d6d2dd490a42bc86ad518dceb878e1f52.camel@linux.intel.com>
Date: Thu, 22 Feb 2024 10:52:31 +0100
From: Thomas Hellström <thomas.hellstrom@...ux.intel.com>
To: David Gow <davidgow@...gle.com>, Linus Torvalds
 <torvalds@...ux-foundation.org>, Shuah Khan <skhan@...uxfoundation.org>, 
 Guenter Roeck <linux@...ck-us.net>, Rae Moar <rmoar@...gle.com>, Matthew
 Auld <matthew.auld@...el.com>,  Arunpravin Paneer Selvam
 <arunpravin.paneerselvam@....com>, Christian König
 <christian.koenig@....com>, Kees Cook <keescook@...omium.org>,
 Maíra Canal <mcanal@...lia.com>,  Rodrigo Vivi
 <rodrigo.vivi@...el.com>, Matthew Brost <matthew.brost@...el.com>, Willem
 de Bruijn <willemb@...gle.com>, Florian Westphal <fw@...len.de>, Cassio
 Neri <cassio.neri@...il.com>, Javier Martinez Canillas
 <javierm@...hat.com>,  Arthur Grillo <arthur.grillo@....br>
Cc: Brendan Higgins <brendan.higgins@...ux.dev>, Daniel Latypov
 <dlatypov@...gle.com>, Stephen Boyd <sboyd@...nel.org>, David Airlie
 <airlied@...il.com>, Maxime Ripard <mripard@...nel.org>, "David S . Miller"
 <davem@...emloft.net>, dri-devel@...ts.freedesktop.org, 
 linux-kernel@...r.kernel.org, intel-xe@...ts.freedesktop.org, 
 linux-rtc@...r.kernel.org, linux-kselftest@...r.kernel.org, 
 kunit-dev@...glegroups.com, linux-hardening@...r.kernel.org, 
 netdev@...r.kernel.org
Subject: Re: [PATCH 8/9] drm/xe/tests: Fix printf format specifiers in
 xe_migrate test

On Wed, 2024-02-21 at 17:27 +0800, David Gow wrote:
> KUNIT_FAIL() is used to fail the xe_migrate test when an error
> occurs.
> However, there's a mismatch in the format specifier: '%li' is used to
> log 'err', which is an 'int'.
> 
> Use '%i' instead of '%li', and for the case where we're printing an
> error pointer, just use '%pe', instead of extracting the error code
> manually with PTR_ERR(). (This also results in a nicer output when
> the
> error code is known.)
> 
> Fixes: dd08ebf6c352 ("drm/xe: Introduce a new DRM driver for Intel
> GPUs")
> Signed-off-by: David Gow <davidgow@...gle.com>

Ack to merge through the Kunit tree.
Acked-by: Thomas Hellström <thomas.hellstrom@...ux.intel.com>