linux-hardening - Re: [PATCH 6/9] fortify: Split reporting and avoid passing string pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Thu, 22 Feb 2024 19:11:28 +0200
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Kees Cook <keescook@...omium.org>
Cc: Arnd Bergmann <arnd@...db.de>, kernel test robot <lkp@...el.com>, linux-hardening@...r.kernel.org, 
	llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev, 
	Andy Shevchenko <andy@...nel.org>, Cezary Rojewski <cezary.rojewski@...el.com>, 
	Puyou Lu <puyou.lu@...il.com>, Mark Brown <broonie@...nel.org>, 
	Josh Poimboeuf <jpoimboe@...nel.org>, Peter Zijlstra <peterz@...radead.org>, 
	Brendan Higgins <brendan.higgins@...ux.dev>, David Gow <davidgow@...gle.com>, 
	Andrew Morton <akpm@...ux-foundation.org>, 
	Linux Memory Management List <linux-mm@...ck.org>, Nathan Chancellor <nathan@...nel.org>, 
	Alexander Potapenko <glider@...gle.com>, Zhaoyang Huang <zhaoyang.huang@...soc.com>, 
	Randy Dunlap <rdunlap@...radead.org>, Geert Uytterhoeven <geert+renesas@...der.be>, 
	Miguel Ojeda <ojeda@...nel.org>, Nick Desaulniers <ndesaulniers@...gle.com>, 
	"Liam R. Howlett" <liam.howlett@...cle.com>, Vlastimil Babka <vbabka@...e.cz>, 
	Dan Williams <dan.j.williams@...el.com>, Rasmus Villemoes <linux@...musvillemoes.dk>, 
	Yury Norov <yury.norov@...il.com>, "Jason A . Donenfeld" <Jason@...c4.com>, 
	Sander Vanheule <sander@...nheule.net>, Eric Biggers <ebiggers@...gle.com>, 
	Masami Hiramatsu <mhiramat@...nel.org>, Andrey Konovalov <andreyknvl@...il.com>, 
	Linus Walleij <linus.walleij@...aro.org>
Subject: Re: [PATCH 6/9] fortify: Split reporting and avoid passing string pointer

On Thu, Feb 22, 2024 at 6:30 PM Kees Cook <keescook@...omium.org> wrote:
> On Thu, Feb 22, 2024 at 02:00:26PM +0100, Arnd Bergmann wrote:
> > On Thu, Apr 6, 2023, at 13:19, kernel test robot wrote:
> >
> > > If you fix the issue, kindly add following tag where applicable
> > > | Reported-by: kernel test robot <lkp@...el.com>
> > > | Link:
> > > https://lore.kernel.org/oe-kbuild-all/202304061930.4Au0PASm-lkp@intel.com/
> > >
> > > All errors (new ones prefixed by >>):
> > >
> > >>> ld.lld: error: undefined symbol: __fortify_panic
> > >    >>> referenced by fortify-string.h:208 (include/linux/fortify-string.h:208)
> > >    >>>               arch/arm/boot/compressed/fdt_ro.o:(fdt_stringlist_count)
> > >    >>> referenced by fortify-string.h:208 (include/linux/fortify-string.h:208)
> > >    >>>               arch/arm/boot/compressed/fdt_ro.o:(fdt_stringlist_search)
> > >    >>> referenced by fortify-string.h:208 (include/linux/fortify-string.h:208)
> > >    >>>               arch/arm/boot/compressed/fdt_ro.o:(fdt_stringlist_get)
> >
> > I get a related build failure from the same commit:
> >
> > arch/arm/boot/compressed/misc.c:157:6: error: no previous prototype for '__fortify_panic' [-Werror=missing-prototypes]
> >   157 | void __fortify_panic(const u8 reason, size_t avail, size_t size)
>
> Whoops, thank you! This series got a refresh after you did the
> missing-prototypes work and I missed this one. I've fixed it and
> double-checked for any others. Hopefully this will be clean in the next
> -next. :)

Thank you! (FWIW, I also hit it today)

-- 
With Best Regards,
Andy Shevchenko