linux-hardening - Re: [PATCH 1/7] scsi: mpi3mr: replace deprecated strncpy with strscpy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <512c1700-b333-8aea-f19b-707523ac3a6e@linux-m68k.org>
Date: Sat, 24 Feb 2024 10:58:07 +1100 (AEDT)
From: Finn Thain <fthain@...ux-m68k.org>
To: Justin Stitt <justinstitt@...gle.com>
cc: Sathya Prakash Veerichetty <sathya.prakash@...adcom.com>,
     Kashyap Desai <kashyap.desai@...adcom.com>,
     Sumit Saxena <sumit.saxena@...adcom.com>,
     Sreekanth Reddy <sreekanth.reddy@...adcom.com>,
     "James E.J. Bottomley" <jejb@...ux.ibm.com>,
     "Martin K. Petersen" <martin.petersen@...cle.com>,
     Suganath Prabu Subramani <suganath-prabu.subramani@...adcom.com>,
     Ariel Elior <aelior@...vell.com>,
 Manish Chopra <manishc@...vell.com>,
     "David S. Miller" <davem@...emloft.net>,
     Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
     Paolo Abeni <pabeni@...hat.com>,
 Saurav Kashyap <skashyap@...vell.com>,
     Javed Hasan <jhasan@...vell.com>,
 GR-QLogic-Storage-Upstream@...vell.com,
     Nilesh Javali <njavali@...vell.com>,
     Manish Rangankar <mrangankar@...vell.com>,
     Don Brace <don.brace@...rochip.com>,
 mpi3mr-linuxdrv.pdl@...adcom.com,     linux-scsi@...r.kernel.org,
 linux-hardening@...r.kernel.org,     linux-kernel@...r.kernel.org,
 Kees Cook <keescook@...omium.org>,     MPT-FusionLinux.pdl@...adcom.com,
 netdev@...r.kernel.org,     storagedev@...rochip.com
Subject: Re: [PATCH 1/7] scsi: mpi3mr: replace deprecated strncpy with
 strscpy


On Fri, 23 Feb 2024, Justin Stitt wrote:

> Really, there's no bug with the current code. 

If (hypothetically) you needed to reduce stack size, just copy the char 
pointer instead of copying the chars onto the stack.

If (hypothetically) strncpy() was banned altogether (rather than merely 
deprecated) I would do the same -- but I'm not the maintainer.