linux-hardening - Re: [PATCH] sparc: vdso: Disable UBSAN instrumentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Thu, 29 Feb 2024 13:32:53 -0800
From: Kees Cook <keescook@...omium.org>
To: Andy Shevchenko <andriy.shevchenko@...el.com>
Cc: "David S. Miller" <davem@...emloft.net>,
	Andreas Larsson <andreas@...sler.com>,
	Masahiro Yamada <masahiroy@...nel.org>,
	Sam Ravnborg <sam@...nborg.org>, Helge Deller <deller@....de>,
	Guo Ren <guoren@...nel.org>, sparclinux@...r.kernel.org,
	Catalin Marinas <catalin.marinas@....com>,
	"Russell King (Oracle)" <rmk+kernel@...linux.org.uk>,
	linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org
Subject: Re: [PATCH] sparc: vdso: Disable UBSAN instrumentation

On Thu, Feb 29, 2024 at 10:00:38PM +0200, Andy Shevchenko wrote:
> On Fri, Feb 23, 2024 at 08:59:45AM -0800, Kees Cook wrote:
> > The UBSAN instrumentation cannot work in the vDSO since it is executing
> > in userspace, so disable it in the Makefile. Fixes the build failures
> > such as:
> > 
> > arch/sparc/vdso/vclock_gettime.c:217: undefined reference to `__ubsan_handle_shift_out_of_bounds'
> > 
> > Signed-off-by: Kees Cook <keescook@...omium.org>
> > ---
> > Cc: "David S. Miller" <davem@...emloft.net>
> > Cc: Andreas Larsson <andreas@...sler.com>
> > Cc: Masahiro Yamada <masahiroy@...nel.org>
> > Cc: Sam Ravnborg <sam@...nborg.org>
> > Cc: Helge Deller <deller@....de>
> > Cc: Guo Ren <guoren@...nel.org>
> > Cc: sparclinux@...r.kernel.org
> 
> I dunno how you applied patches, but these Cc seems to appear in a few commits
> in your hardening branch.
> 
> I formatted patch from 9fd54b08040669, checked out the new branch just before
> this commit and run `git am 0001-...`. I don't see them.

Ah, hm, yes, I'll need to split up my trees a bit to get the right
results. Thanks for pointing that out!

-- 
Kees Cook