[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <328306d9-953f-482b-bf9a-a753d7d4e2ed@quicinc.com>
Date: Tue, 19 Mar 2024 15:54:27 -0700
From: Jeff Johnson <quic_jjohnson@...cinc.com>
To: "Gustavo A. R. Silva" <gustavo@...eddedor.com>,
Kalle Valo
<kvalo@...nel.org>
CC: <linux-wireless@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org>,
<linux-hardening@...r.kernel.org>
Subject: Re: [RFC] wireless: ti: Can we just remove this flexible array?
On 3/19/2024 2:59 PM, Gustavo A. R. Silva wrote:
> Hi!
>
> `struct wl1271_cmd_header` is currently embedded in multiple other
> structs, and it's causing many `-Wflex-array-member-not-at-end` warnings.
>
> Has this flexible-array member been used in the past or is it intended
> for future use?
>
> Otherwise, I think we could just remove it.
>
> diff --git a/drivers/net/wireless/ti/wlcore/cmd.h b/drivers/net/wireless/ti/wlcore/cmd.h
> index f2609d5b6bf7..4c2f2608ef3b 100644
> --- a/drivers/net/wireless/ti/wlcore/cmd.h
> +++ b/drivers/net/wireless/ti/wlcore/cmd.h
> @@ -208,8 +208,6 @@ enum cmd_templ {
> struct wl1271_cmd_header {
> __le16 id;
> __le16 status;
> - /* payload */
> - u8 data[];
> } __packed;
I'd think you should just remove it
Powered by blists - more mailing lists