linux-hardening - Re: [PATCH v3] soc: qcom: cmd-db: replace deprecated strncpy with strtomem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <171373856769.1196479.1804405630456306049.b4-ty@kernel.org>
Date: Sun, 21 Apr 2024 17:29:13 -0500
From: Bjorn Andersson <andersson@...nel.org>
To: Konrad Dybcio <konrad.dybcio@...aro.org>,
	Justin Stitt <justinstitt@...gle.com>
Cc: linux-arm-msm@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	linux-hardening@...r.kernel.org,
	Kees Cook <keescook@...omium.org>
Subject: Re: [PATCH v3] soc: qcom: cmd-db: replace deprecated strncpy with strtomem


On Tue, 19 Mar 2024 21:19:59 +0000, Justin Stitt wrote:
> strncpy() is an ambiguous and potentially dangerous interface [1]. We
> should prefer more robust and less ambiguous alternatives.
> 
> @query is marked as __nonstring and doesn't need to be NUL-terminated.
> 
> Since we are doing a string to memory copy, we can use the aptly named
> "strtomem" -- specifically, the "pad" variant to also ensure NUL-padding
> throughout the destination buffer.
> 
> [...]

Applied, thanks!

[1/1] soc: qcom: cmd-db: replace deprecated strncpy with strtomem
      commit: 166db01007ea802ff9933ac73ec8f140ca0cf5d5

Best regards,
-- 
Bjorn Andersson <andersson@...nel.org>