linux-hardening - Re: [PATCH 0/5] scsi: Avoid possible run-time warning with long manufacturer strings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Wed, 24 Apr 2024 21:55:02 -0400
From: "Martin K. Petersen" <martin.petersen@...cle.com>
To: Kees Cook <keescook@...omium.org>
Cc: "Martin K . Petersen" <martin.petersen@...cle.com>,
        Charles Bertsch
 <cbertsch@....net>,
        Justin Stitt <justinstitt@...gle.com>,
        Bart Van
 Assche <bvanassche@....org>,
        Andy Shevchenko <andy@...nel.org>,
        Sathya
 Prakash <sathya.prakash@...adcom.com>,
        Sreekanth Reddy
 <sreekanth.reddy@...adcom.com>,
        Suganath Prabu Subramani
 <suganath-prabu.subramani@...adcom.com>,
        "James E.J. Bottomley"
 <jejb@...ux.ibm.com>,
        Kashyap Desai <kashyap.desai@...adcom.com>,
        Sumit
 Saxena <sumit.saxena@...adcom.com>,
        Nilesh Javali <njavali@...vell.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Himanshu Madhani
 <himanshu.madhani@...cle.com>,
        linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org,
        MPT-FusionLinux.pdl@...adcom.com, linux-scsi@...r.kernel.org,
        mpi3mr-linuxdrv.pdl@...adcom.com,
        GR-QLogic-Storage-Upstream@...vell.com
Subject: Re: [PATCH 0/5] scsi: Avoid possible run-time warning with long
 manufacturer strings


Kees,

> This series fixes all 4 of the instances I could find in the SCSI
> subsystem.

Looks OK to me.

Minor nit: I do find it a bit odd to think of a string as "memory".
Maybe that's just because I am so used to always having to distinguish
between fixed length strings and NUL-terminated strings in the storage
protocols and hardware programming interfaces. But both types are
definitely referred to as "strings" colloquially and not so much
"memory".

Reviewed-by: Martin K. Petersen <martin.petersen@...cle.com>

-- 
Martin K. Petersen	Oracle Linux Engineering