linux-hardening - Re: [PATCH] efi: pstore: Return proper errors on UEFI failures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202405191114.1DD51BDC1C@keescook>
Date: Sun, 19 May 2024 11:15:11 -0700
From: Kees Cook <keescook@...omium.org>
To: "Guilherme G. Piccoli" <gpiccoli@...lia.com>
Cc: linux-efi@...r.kernel.org, linux-hardening@...r.kernel.org,
	tony.luck@...el.com, ardb@...nel.org, kernel@...ccoli.net,
	kernel-dev@...lia.com
Subject: Re: [PATCH] efi: pstore: Return proper errors on UEFI failures

On Sun, May 19, 2024 at 01:33:53PM -0300, Guilherme G. Piccoli wrote:
> Right now efi-pstore either returns 0 (success) or -EIO; but we
> do have a function to convert UEFI errors in different standard
> error codes, helping to narrow down potential issues more accurately.
> 
> So, let's use this helper here.
> 
> Signed-off-by: Guilherme G. Piccoli <gpiccoli@...lia.com>

Ah yeah, good idea!

Reviewed-by: Kees Cook <keescook@...omium.org>

-- 
Kees Cook