linux-hardening - Re: [WARNING] memcpy: detected field-spanning write (size 1005) of single field "&out_cmd->cmd.payload" at drivers/net/wireless/intel/iwlegacy/common.c:3173 (size 320)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <daf3e4248061c21db623be84136f3da1da5de513.camel@sipsolutions.net>
Date: Mon, 20 May 2024 17:10:18 +0200
From: Johannes Berg <johannes@...solutions.net>
To: Stanislaw Gruszka <stf_xl@...pl>
Cc: Kees Cook <keescook@...omium.org>, "Gustavo A. R. Silva"
	 <gustavoars@...nel.org>, Xose Vazquez Perez <xose.vazquez@...il.com>, 
	linux-wireless@...r.kernel.org, linux-hardening@...r.kernel.org
Subject: Re: [WARNING] memcpy: detected field-spanning write (size 1005) of
 single field "&out_cmd->cmd.payload" at
 drivers/net/wireless/intel/iwlegacy/common.c:3173 (size 320)

On Mon, 2024-05-20 at 17:08 +0200, Stanislaw Gruszka wrote:
> > 
> > I don't think this is right, now the raw comes after
> > DEF_CMD_PAYLOAD_SIZE? You want it to be a union with payload, I'd think.
> 
> Not sure if I understand. I think we have union with payload with 
> the patch. The structure looks like this:
> 
> struct il_device_cmd {
> 	struct il_cmd_header hdr;	/* uCode API */
> 	union {
> 		u32 flags;
> 		u8 val8;
> 		u16 val16;
> 		u32 val32;
> 		struct il_tx_cmd tx;
> 		u8 payload[DEF_CMD_PAYLOAD_SIZE];
> 		DECLARE_FLEX_ARRAY(u8, raw);
> 	} __packed cmd;
> } __packed;
> 

Oh, sorry, my bad. I confused the tx_cmd and the cmd_header.

johannes