linux-hardening - Re: [WARNING] memcpy: detected field-spanning write (size 1005) of single field "&out_cmd->cmd.payload" at drivers/net/wireless/intel/iwlegacy/common.c:3173 (size 320)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <95f3e147de837b4833e6cf6eb67108f96640af4e.camel@sipsolutions.net>
Date: Mon, 20 May 2024 13:45:37 +0200
From: Johannes Berg <johannes@...solutions.net>
To: Stanislaw Gruszka <stf_xl@...pl>, Kees Cook <keescook@...omium.org>
Cc: "Gustavo A. R. Silva" <gustavoars@...nel.org>, Xose Vazquez Perez
	 <xose.vazquez@...il.com>, linux-wireless@...r.kernel.org, 
	linux-hardening@...r.kernel.org
Subject: Re: [WARNING] memcpy: detected field-spanning write (size 1005) of
 single field "&out_cmd->cmd.payload" at
 drivers/net/wireless/intel/iwlegacy/common.c:3173 (size 320)


> +++ b/drivers/net/wireless/intel/iwlegacy/commands.h
> @@ -201,9 +201,6 @@ struct il_cmd_header {
>  	 *  15          unsolicited RX or uCode-originated notification
>  	 */
>  	__le16 sequence;
> -
> -	/* command or response/notification data follows immediately */
> -	u8 data[];
>  } __packed;

[...]


> -	memcpy(&out_cmd->cmd.payload, cmd->data, cmd->len);
> +	memcpy(&out_cmd->cmd.raw, cmd->data, cmd->len);

[...]

> +++ b/drivers/net/wireless/intel/iwlegacy/common.h
> @@ -555,6 +555,7 @@ struct il_device_cmd {
>  		u32 val32;
>  		struct il_tx_cmd tx;
>  		u8 payload[DEF_CMD_PAYLOAD_SIZE];
> +		DECLARE_FLEX_ARRAY(u8, raw);
> 

I don't think this is right, now the raw comes after
DEF_CMD_PAYLOAD_SIZE? You want it to be a union with payload, I'd think.

johannes