linux-hardening - Re: [PATCH net-next v2] net: mana: Allow variable size indirection table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240530084119.684e2783@kernel.org>
Date: Thu, 30 May 2024 08:41:19 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Shradha Gupta <shradhagupta@...ux.microsoft.com>
Cc: linux-hardening@...r.kernel.org, netdev@...r.kernel.org,
 linux-hyperv@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-rdma@...r.kernel.org, Colin Ian King <colin.i.king@...il.com>, Ahmed
 Zaki <ahmed.zaki@...el.com>, Pavan Chebbi <pavan.chebbi@...adcom.com>,
 Souradeep Chakrabarti <schakrabarti@...ux.microsoft.com>, Konstantin
 Taranov <kotaranov@...rosoft.com>, Kees Cook <keescook@...omium.org>, Paolo
 Abeni <pabeni@...hat.com>, Eric Dumazet <edumazet@...gle.com>, "David S.
 Miller" <davem@...emloft.net>, Dexuan Cui <decui@...rosoft.com>, Wei Liu
 <wei.liu@...nel.org>, Haiyang Zhang <haiyangz@...rosoft.com>, "K. Y.
 Srinivasan" <kys@...rosoft.com>, Leon Romanovsky <leon@...nel.org>, Jason
 Gunthorpe <jgg@...pe.ca>, Ajay Sharma <sharmaajay@...rosoft.com>, Long Li
 <longli@...rosoft.com>, Shradha Gupta <shradhagupta@...rosoft.com>
Subject: Re: [PATCH net-next v2] net: mana: Allow variable size indirection
 table

On Tue, 28 May 2024 22:35:55 -0700 Shradha Gupta wrote:
> +	save_table = kcalloc(apc->indir_table_sz, sizeof(u32), GFP_KERNEL);
> +	if (!save_table)
> +		return -ENOMEM;
> +
>  	if (rxfh->indir) {
> -		for (i = 0; i < MANA_INDIRECT_TABLE_SIZE; i++)
> +		for (i = 0; i < apc->indir_table_sz; i++)
>  			if (rxfh->indir[i] >= apc->num_queues)
>  				return -EINVAL;

leaks save_table