Message-ID: <20240604115235.044acfd6@gandalf.local.home>
Date: Tue, 4 Jun 2024 11:52:35 -0400
From: Steven Rostedt <rostedt@...dmis.org>
To: Jani Nikula <jani.nikula@...ux.intel.com>
Cc: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, "Rafael J. Wysocki"
 <rafael.j.wysocki@...el.com>, Greg Kroah-Hartman
 <gregkh@...uxfoundation.org>, Corey Minyard <minyard@....org>, Allen Pais
 <apais@...ux.microsoft.com>, Sebastian Reichel
 <sebastian.reichel@...labora.com>, Perry Yuan <perry.yuan@....com>,
 Giovanni Cabiddu <giovanni.cabiddu@...el.com>, Herbert Xu
 <herbert@...dor.apana.org.au>, Nuno Sa <nuno.sa@...log.com>, Guenter Roeck
 <linux@...ck-us.net>, Randy Dunlap <rdunlap@...radead.org>, Andi Shyti
 <andi.shyti@...nel.org>, Heiner Kallweit <hkallweit1@...il.com>, Lee Jones
 <lee@...nel.org>, Samuel Holland <samuel@...lland.org>, Elad Nachman
 <enachman@...vell.com>, Arseniy Krasnov <AVKrasnov@...rdevices.ru>,
 Johannes Berg <johannes.berg@...el.com>, Gregory Greenman
 <gregory.greenman@...el.com>, Benjamin Berg <benjamin.berg@...el.com>,
 Bjorn Helgaas <bhelgaas@...gle.com>, Robert Richter <rrichter@....com>,
 Vinod Koul <vkoul@...nel.org>, Chunfeng Yun <chunfeng.yun@...iatek.com>,
 Linus Walleij <linus.walleij@...aro.org>, Hans de Goede
 <hdegoede@...hat.com>, Ilpo Järvinen
 <ilpo.jarvinen@...ux.intel.com>, Nikita Kravets <teackot@...il.com>, Jiri
 Slaby <jirislaby@...nel.org>, Srinivas Pandruvada
 <srinivas.pandruvada@...ux.intel.com>, Stanley Chang
 <stanley_chang@...ltek.com>, Heikki Krogerus
 <heikki.krogerus@...ux.intel.com>, Abdel Alkuor <abdelalkuor@...tab.com>,
 Kent Overstreet <kent.overstreet@...ux.dev>, Eric Biggers
 <ebiggers@...gle.com>, Kees Cook <keescook@...omium.org>, Ingo Molnar
 <mingo@...nel.org>, Daniel Bristot de Oliveira <bristot@...nel.org>, Andrew
 Morton <akpm@...ux-foundation.org>, Hugh Dickins <hughd@...gle.com>, Abel
 Wu <wuyun.abel@...edance.com>, John Johansen <john.johansen@...onical.com>,
 Mimi Zohar <zohar@...ux.ibm.com>, Stefan Berger <stefanb@...ux.ibm.com>,
 Roberto Sassu <roberto.sassu@...wei.com>, Eric Snowberg
 <eric.snowberg@...cle.com>, Takashi Iwai <tiwai@...e.de>, Takashi Sakamoto
 <o-takashi@...amocchi.jp>, Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>,
 Mark Brown <broonie@...nel.org>, Kuninori Morimoto
 <kuninori.morimoto.gx@...esas.com>, linuxppc-dev@...ts.ozlabs.org,
 linux-kernel@...r.kernel.org, keyrings@...r.kernel.org,
 linux-crypto@...r.kernel.org, linux-acpi@...r.kernel.org,
 linux-ide@...r.kernel.org, openipmi-developer@...ts.sourceforge.net,
 linux-clk@...r.kernel.org, linux-rpi-kernel@...ts.infradead.org,
 linux-arm-kernel@...ts.infradead.org, linux-rockchip@...ts.infradead.org,
 linux-tegra@...r.kernel.org, linux-pm@...r.kernel.org, qat-linux@...el.com,
 dri-devel@...ts.freedesktop.org, intel-gfx@...ts.freedesktop.org,
 intel-xe@...ts.freedesktop.org, nouveau@...ts.freedesktop.org,
 linux-hwmon@...r.kernel.org, linux-i2c@...r.kernel.org,
 linux-leds@...r.kernel.org, linux-sunxi@...ts.linux.dev,
 linux-omap@...r.kernel.org, linux-mmc@...r.kernel.org,
 linux-mtd@...ts.infradead.org, netdev@...r.kernel.org,
 linux-wireless@...r.kernel.org, linux-pci@...r.kernel.org,
 linux-mediatek@...ts.infradead.org, linux-phy@...ts.infradead.org,
 linux-gpio@...r.kernel.org, platform-driver-x86@...r.kernel.org,
 linux-staging@...ts.linux.dev, linux-usb@...r.kernel.org,
 linux-fbdev@...r.kernel.org, linux-bcachefs@...r.kernel.org,
 linux-hardening@...r.kernel.org, cgroups@...r.kernel.org,
 linux-trace-kernel@...r.kernel.org, linux-mm@...ck.org,
 apparmor@...ts.ubuntu.com, linux-security-module@...r.kernel.org,
 linux-integrity@...r.kernel.org, alsa-devel@...a-project.org,
 linux-sound@...r.kernel.org, Michael Ellerman <mpe@...erman.id.au>,
 Nicholas Piggin <npiggin@...il.com>, Christophe Leroy
 <christophe.leroy@...roup.eu>, "Naveen N. Rao"
 <naveen.n.rao@...ux.ibm.com>, Thomas Gleixner <tglx@...utronix.de>, Ingo
 Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>, Dave Hansen
 <dave.hansen@...ux.intel.com>, x86@...nel.org, "H. Peter Anvin"
 <hpa@...or.com>, David Howells <dhowells@...hat.com>, "David S. Miller"
 <davem@...emloft.net>, "Rafael J. Wysocki" <rafael@...nel.org>, Len Brown
 <lenb@...nel.org>, Sergey Shtylyov <s.shtylyov@....ru>, Damien Le Moal
 <dlemoal@...nel.org>, Niklas Cassel <cassel@...nel.org>, Daniel Scally
 <djrscally@...il.com>, Sakari Ailus <sakari.ailus@...ux.intel.com>, Michael
 Turquette <mturquette@...libre.com>, Stephen Boyd <sboyd@...nel.org>,
 Florian Fainelli <florian.fainelli@...adcom.com>, Ray Jui
 <rjui@...adcom.com>, Scott Branden <sbranden@...adcom.com>, Broadcom
 internal kernel review list <bcm-kernel-feedback-list@...adcom.com>, Heiko
 Stuebner <heiko@...ech.de>, Peter De Schrijver <pdeschrijver@...dia.com>,
 Prashant Gaikwad <pgaikwad@...dia.com>, Thierry Reding
 <thierry.reding@...il.com>, Jonathan Hunter <jonathanh@...dia.com>, Huang
 Rui <ray.huang@....com>, "Gautham R. Shenoy" <gautham.shenoy@....com>,
 Mario Limonciello <mario.limonciello@....com>, Viresh Kumar
 <viresh.kumar@...aro.org>, Maarten Lankhorst
 <maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>,
 Thomas Zimmermann <tzimmermann@...e.de>, David Airlie <airlied@...il.com>,
 Daniel Vetter <daniel@...ll.ch>, Rodrigo Vivi <rodrigo.vivi@...el.com>,
 Joonas Lahtinen <joonas.lahtinen@...ux.intel.com>, Tvrtko Ursulin
 <tursulin@...ulin.net>, Karol Herbst <kherbst@...hat.com>, Lyude Paul
 <lyude@...hat.com>, Danilo Krummrich <dakr@...hat.com>, Jean Delvare
 <jdelvare@...e.com>, Alexander Shishkin
 <alexander.shishkin@...ux.intel.com>, Pavel Machek <pavel@....cz>, Chen-Yu
 Tsai <wens@...e.org>, Jernej Skrabec <jernej.skrabec@...il.com>, Tony
 Lindgren <tony@...mide.com>, Adrian Hunter <adrian.hunter@...el.com>, Hu
 Ziji <huziji@...vell.com>, Ulf Hansson <ulf.hansson@...aro.org>, Miquel
 Raynal <miquel.raynal@...tlin.com>, Richard Weinberger <richard@....at>,
 Vignesh Raghavendra <vigneshr@...com>, Potnuri Bharat Teja
 <bharat@...lsio.com>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
 <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Miri Korenblit
 <miriam.rachel.korenblit@...el.com>, Kalle Valo <kvalo@...nel.org>, Mahesh
 J Salgaonkar <mahesh@...ux.ibm.com>, Oliver O'Halloran <oohall@...il.com>,
 Kishon Vijay Abraham I <kishon@...nel.org>, Matthias Brugger
 <matthias.bgg@...il.com>, AngeloGioacchino Del Regno
 <angelogioacchino.delregno@...labora.com>, JC Kuo <jckuo@...dia.com>,
 Andrew Lunn <andrew@...n.ch>, Gregory Clement
 <gregory.clement@...tlin.com>, Sebastian Hesselbarth
 <sebastian.hesselbarth@...il.com>, Sebastian Reichel <sre@...nel.org>,
 Daniel Lezcano <daniel.lezcano@...aro.org>, Zhang Rui
 <rui.zhang@...el.com>, Lukasz Luba <lukasz.luba@....com>, Thinh Nguyen
 <Thinh.Nguyen@...opsys.com>, Helge Deller <deller@....de>, Brian Foster
 <bfoster@...hat.com>, Zhihao Cheng <chengzhihao1@...wei.com>, Tejun Heo
 <tj@...nel.org>, Zefan Li <lizefan.x@...edance.com>, Johannes Weiner
 <hannes@...xchg.org>, Peter Zijlstra <peterz@...radead.org>, Juri Lelli
 <juri.lelli@...hat.com>, Vincent Guittot <vincent.guittot@...aro.org>,
 Dietmar Eggemann <dietmar.eggemann@....com>, Ben Segall
 <bsegall@...gle.com>, Mel Gorman <mgorman@...e.de>, Daniel Bristot de
 Oliveira <bristot@...hat.com>, Valentin Schneider <vschneid@...hat.com>,
 Masami Hiramatsu <mhiramat@...nel.org>, Mathieu Desnoyers
 <mathieu.desnoyers@...icios.com>, Jason Baron <jbaron@...mai.com>, Jim
 Cromie <jim.cromie@...il.com>, Paul Moore <paul@...l-moore.com>, James
 Morris <jmorris@...ei.org>, "Serge E. Hallyn" <serge@...lyn.com>, Dmitry
 Kasatkin <dmitry.kasatkin@...il.com>, Clemens Ladisch <clemens@...isch.de>,
 Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>, Liam
 Girdwood <lgirdwood@...il.com>, Linus Torvalds
 <torvalds@...ux-foundation.org>
Subject: Re: [PATCH v1 1/1] treewide: Align match_string() with
 sysfs_match_string()

On Tue, 04 Jun 2024 10:45:37 +0300
Jani Nikula <jani.nikula@...ux.intel.com> wrote:

> On Sun, 02 Jun 2024, Andy Shevchenko <andriy.shevchenko@...ux.intel.com> wrote:
> > Make two APIs look similar. Hence convert match_string() to be
> > a 2-argument macro. In order to avoid unneeded churn, convert
> > all users as well. There is no functional change intended.  
> 
> Why do we think it's a good idea to increase and normalize the use of
> double-underscore function names across the kernel, like
> __match_string() in this case? It should mean "reserved for the
> implementation, not to be called directly".
> 
> If it's to be used directly, it should be named accordingly, right?
> 
> Being in line with __sysfs_match_string() isn't a great argument alone,
> because this adds three times the number of __match_string() calls than
> there are __sysfs_match_string() calls. It's not a good model to follow.
> Arguably both should be renamed.

Agreed. I want to get rid of any functions starting with an underscore
except for those that are basically the same function used internally for
convenience.

Perhaps "match_string_dynamic()"? Where it is used for dynamically
allocated arrays without known size. Or, allow a third parameter for
dynamic arrays.

#define match_string(_a, _s, ...)
	char _______STR[] = __stringify((__VA_ARGS__));	\
	if (sizeof(_______STR) > 3)			\
		__match_string(_a, _s, ##__VA_ARGS__);  \
	else						\
		__match_string(_a, _s, ARRAY_SIZE(_a));

What the above stringify((__VA_ARGS__)) does is to check the size of any
args added to match_string(). if there isn't any, it will turn into:
"()\0", which is of size 3. If you add an argument, it will be:
"(<arg>)\0", which will have a size greater than three.

(trace_printk() does this trick in include/linux/kernel.h).

This way, both:

 match_string(array, sting);

or

 match_string(array, string, size);

will work.

-- Steve

Powered by blists - more mailing lists