[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20240605214944.22113-1-jain.abhinav177@gmail.com>
Date: Wed, 5 Jun 2024 21:49:44 +0000
From: Abhinav Jain <jain.abhinav177@...il.com>
To: keescook@...omium.org,
tony.luck@...el.com,
gpiccoli@...lia.com,
linux-hardening@...r.kernel.org,
linux-kernel@...r.kernel.org
Cc: skhan@...uxfoundation.org,
javier.carrasco.cruz@...il.com,
jain.abhinav177@...il.com,
julia.lawall@...ia.fr
Subject: [PATCH v2] pstore/ram: Replace of_node_put with __free() for automatic cleanup
Add __free(device_node) to the parent_node struct declaration
Add changes to incorporate the review comments from v1
Signed-off-by: Abhinav Jain <jain.abhinav177@...il.com>
PATCH v1 link:
https://lore.kernel.org/all/20240415161409.8375-1-jain.abhinav177@gmail.com/
Changes since v1:
- Moved the variable definition back to the top of the function body
---
fs/pstore/ram.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/pstore/ram.c b/fs/pstore/ram.c
index 14f2f4864e48..f8258e4567c3 100644
--- a/fs/pstore/ram.c
+++ b/fs/pstore/ram.c
@@ -644,6 +644,7 @@ static int ramoops_parse_dt(struct platform_device *pdev,
struct ramoops_platform_data *pdata)
{
struct device_node *of_node = pdev->dev.of_node;
+ struct device_node *parent_node __free(device_node) = of_node_parent(of_node);
struct resource *res;
u32 value;
int ret;
@@ -703,7 +704,6 @@ static int ramoops_parse_dt(struct platform_device *pdev,
* we're not a child of "reserved-memory" and mimicking the
* expected behavior.
*/
- struct device_node *parent_node __free(device_node) = of_node_parent(of_node);
if (!of_node_name_eq(parent_node, "reserved-memory") &&
!pdata->console_size && !pdata->ftrace_size &&
!pdata->pmsg_size && !pdata->ecc_info.ecc_size) {
--
2.34.1
Powered by blists - more mailing lists