linux-hardening - Re: [PATCH] Input: joystick - use sizeof(*pointer) instead of sizeof(type)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZmYhfNmyjX6OiJP4@google.com>
Date: Sun, 9 Jun 2024 14:41:16 -0700
From: Dmitry Torokhov <dmitry.torokhov@...il.com>
To: Erick Archer <erick.archer@...look.com>
Cc: Linus Walleij <linus.walleij@...aro.org>,
	Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
	Vicki Pfau <vi@...rift.com>,
	Brenton Simpson <appsforartists@...gle.com>,
	Max Nguyen <maxwell.nguyen@...com>, Carl Ng <carl.ng@...com>,
	Matt Scialabba <matt.git@...tmail.fm>,
	Christophe JAILLET <christophe.jaillet@...adoo.fr>,
	Kees Cook <keescook@...omium.org>,
	"Gustavo A. R. Silva" <gustavoars@...nel.org>,
	Justin Stitt <justinstitt@...gle.com>, linux-input@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org
Subject: Re: [PATCH] Input: joystick - use sizeof(*pointer) instead of
 sizeof(type)

On Sat, Jun 08, 2024 at 05:13:57PM +0200, Erick Archer wrote:
> It is preferred to use sizeof(*pointer) instead of sizeof(type)
> due to the type of the variable can change and one needs not
> change the former (unlike the latter).
> 
> At the same time refactor the code to not use assignment in "if"
> conditions.
> 
> This patch has no effect on runtime behavior.
> 
> Signed-off-by: Erick Archer <erick.archer@...look.com>

Applied, thank you.

-- 
Dmitry