linux-hardening - Re: [PATCH] crypto: arm/crc32 - add kCFI annotations to asm routines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdbc5ENohiFg4_mEfYk8A74UG2hiECCDfELnMu7ghKa3Ww@mail.gmail.com>
Date: Tue, 11 Jun 2024 23:10:22 +0200
From: Linus Walleij <linus.walleij@...aro.org>
To: Ard Biesheuvel <ardb+git@...gle.com>
Cc: linux-crypto@...r.kernel.org, linux-hardening@...r.kernel.org, 
	herbert@...dor.apana.org.au, Ard Biesheuvel <ardb@...nel.org>, 
	Kees Cook <keescook@...omium.org>
Subject: Re: [PATCH] crypto: arm/crc32 - add kCFI annotations to asm routines

On Mon, Jun 10, 2024 at 5:26 PM Ard Biesheuvel <ardb+git@...gle.com> wrote:

> From: Ard Biesheuvel <ardb@...nel.org>
>
> The crc32/crc32c implementations using the scalar CRC32 instructions are
> accessed via indirect calls, and so they must be annotated with type ids
> in order to execute correctly when kCFI is enabled.
>
> Cc: Kees Cook <keescook@...omium.org>
> Cc: Linus Walleij <linus.walleij@...aro.org>
> Signed-off-by: Ard Biesheuvel <ardb@...nel.org>

Fixes: 1a4fec49efe5 ("ARM: 9392/2: Support CLANG CFI")
Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Thanks for helping to iron out the rough corners on these patches!

Yours,
Linus Walleij